Code review comment for lp:~qcumber-some/widelands/bug704637

Revision history for this message
SirVer (sirver) wrote :

Cool. One more thing I noticed: when disabling opengl, g_opengl (a global variable) must also be set to false. Can you make sure this is the case here? I think this is then ready for merging - feel free to do it yourself or ping me so I can do it. Thanks for fixing this issue!

And secondly - this will still seem strange to users. They choose one mode but they get a completely different one without noticfication (because most will not read the console output). I have no idea how to solve this properly though - some kind of state must be passed back and conserved till we could display a message box. Well, we can find a solution in another patch for this.

review: Approve

« Back to merge proposal