Code review comment for lp:~pwlars/uci-engine/tr-pass-no-tests

Revision history for this message
Celso Providelo (cprov) wrote :

Paul,

Thanks a lot for investigating this issue and finding a reasonable solution.

I, personally, agree with "passing" sources that have no tests in the ci-airline context. However, it has to make sense to our audience as well. Can we have another *representative* opinion on that ?

Meanwhile, can you add a quick unittest (mocking test_package, possibly) documenting/checking this behaviour ? This way we might notice future changes (regressions) like this one.

review: Needs Fixing

« Back to merge proposal