Code review comment for lp:~pwlars/snappy-proposed-selftest-agent/publish-direct-results-exchange

The attempt to merge lp:~pwlars/snappy-proposed-selftest-agent/publish-direct-results-exchange into lp:snappy-proposed-selftest-agent failed. Below is the output from the failed tests.

Using base prefix '/usr'
New python executable in /tmp/venv-snappy-proposed-selftest-agent4imbz5zi/bin/python3
Also creating executable in /tmp/venv-snappy-proposed-selftest-agent4imbz5zi/bin/python
Installing setuptools, pip...done.
Running virtualenv with interpreter /usr/bin/python3
Ignoring indexes: https://pypi.python.org/simple/
Downloading/unpacking kombu==3.0.24 (from -r requirements.txt (line 1))
Downloading/unpacking python-logstash==0.4.2 (from -r requirements.txt (line 2))
  Running setup.py (path:/tmp/venv-snappy-proposed-selftest-agent4imbz5zi/build/python-logstash/setup.py) egg_info for package python-logstash

Downloading/unpacking uservice-utils==1.0.2.1 (from -r requirements.txt (line 3))
Downloading/unpacking amqp>=1.4.5,<2.0 (from kombu==3.0.24->-r requirements.txt (line 1))
  Running setup.py (path:/tmp/venv-snappy-proposed-selftest-agent4imbz5zi/build/amqp/setup.py) egg_info for package amqp

Downloading/unpacking anyjson>=0.3.3 (from kombu==3.0.24->-r requirements.txt (line 1))
  Running setup.py (path:/tmp/venv-snappy-proposed-selftest-agent4imbz5zi/build/anyjson/setup.py) egg_info for package anyjson

Installing collected packages: kombu, python-logstash, uservice-utils, amqp, anyjson
  Running setup.py install for python-logstash

  Running setup.py install for amqp

  Running setup.py install for anyjson
    Fixing build/lib/anyjson/__init__.py
    Skipping implicit fixer: buffer
    Skipping implicit fixer: idioms
    Skipping implicit fixer: set_literal
    Skipping implicit fixer: ws_comma
    Fixing build/lib/anyjson/__init__.py
    Skipping implicit fixer: buffer
    Skipping implicit fixer: idioms
    Skipping implicit fixer: set_literal
    Skipping implicit fixer: ws_comma

Successfully installed kombu python-logstash uservice-utils amqp anyjson
Cleaning up...
Downloading/unpacking flake8==2.4.0 (from -r test_requirements.txt (line 1))
  Downloading flake8-2.4.0-py2.py3-none-any.whl
Downloading/unpacking testtools==1.7.1 (from -r test_requirements.txt (line 2))
Downloading/unpacking pyflakes>=0.8.1,<0.9 (from flake8==2.4.0->-r test_requirements.txt (line 1))
  Downloading pyflakes-0.8.1-py2.py3-none-any.whl
Downloading/unpacking pep8>=1.5.7,<1.6 (from flake8==2.4.0->-r test_requirements.txt (line 1))
  Downloading pep8-1.5.7-py2.py3-none-any.whl
Downloading/unpacking mccabe>=0.2.1,<0.4 (from flake8==2.4.0->-r test_requirements.txt (line 1))
  Downloading mccabe-0.3-py2.py3-none-any.whl
Downloading/unpacking extras (from testtools==1.7.1->-r test_requirements.txt (line 2))
  Downloading extras-0.0.3.tar.gz
  Running setup.py (path:/tmp/venv-snappy-proposed-selftest-agent4imbz5zi/build/extras/setup.py) egg_info for package extras

Downloading/unpacking unittest2>=1.0.0 (from testtools==1.7.1->-r test_requirements.txt (line 2))
Downloading/unpacking python-mimeparse (from testtools==1.7.1->-r test_requirements.txt (line 2))
  Downloading python-mimeparse-0.1.4.tar.gz
  Running setup.py (path:/tmp/venv-snappy-proposed-selftest-agent4imbz5zi/build/python-mimeparse/setup.py) egg_info for package python-mimeparse

Downloading/unpacking traceback2 (from testtools==1.7.1->-r test_requirements.txt (line 2))
  Downloading traceback2-1.4.0-py2.py3-none-any.whl
Downloading/unpacking argparse (from unittest2>=1.0.0->testtools==1.7.1->-r test_requirements.txt (line 2))
  Downloading argparse-1.3.0-py2.py3-none-any.whl
Downloading/unpacking six>=1.4 (from unittest2>=1.0.0->testtools==1.7.1->-r test_requirements.txt (line 2))
  Downloading six-1.9.0-py2.py3-none-any.whl
Downloading/unpacking linecache2 (from traceback2->testtools==1.7.1->-r test_requirements.txt (line 2))
  Downloading linecache2-1.0.0-py2.py3-none-any.whl
Installing collected packages: flake8, testtools, pyflakes, pep8, mccabe, extras, unittest2, python-mimeparse, traceback2, argparse, six, linecache2
*** Error compiling '/tmp/venv-snappy-proposed-selftest-agent4imbz5zi/build/testtools/testtools/_compat2x.py'...
  File "/tmp/venv-snappy-proposed-selftest-agent4imbz5zi/build/testtools/testtools/_compat2x.py", line 16
    raise exc_class, exc_obj, exc_tb
                   ^
SyntaxError: invalid syntax

  Running setup.py install for extras

  Running setup.py install for python-mimeparse

Successfully installed flake8 testtools pyflakes pep8 mccabe extras unittest2 python-mimeparse traceback2 argparse six linecache2
Cleaning up...
running test
running egg_info
creating snappy_proposed_selftest_agent.egg-info
writing snappy_proposed_selftest_agent.egg-info/PKG-INFO
writing dependency_links to snappy_proposed_selftest_agent.egg-info/dependency_links.txt
writing top-level names to snappy_proposed_selftest_agent.egg-info/top_level.txt
writing manifest file 'snappy_proposed_selftest_agent.egg-info/SOURCES.txt'
reading manifest file 'snappy_proposed_selftest_agent.egg-info/SOURCES.txt'
writing manifest file 'snappy_proposed_selftest_agent.egg-info/SOURCES.txt'
running build_ext
running flake8
snappy_proposed_selftest_agent/__init__.py:44:9: F841 local variable 'exchange' is assigned to but never used
INFO: Executing: bzr branch lp:~canonical-ci-engineering/snappy-proposed-selftest-agent/pip-cache /tmp/tmp3aa0v_sppip-cache-/cache
INFO: Executing: virtualenv -p python3 /tmp/venv-snappy-proposed-selftest-agent4imbz5zi
INFO: Executing: /tmp/venv-snappy-proposed-selftest-agent4imbz5zi/bin/pip install --no-index --find-links=/tmp/tmp3aa0v_sppip-cache-/cache -r requirements.txt
INFO: Executing: /tmp/venv-snappy-proposed-selftest-agent4imbz5zi/bin/pip install -r test_requirements.txt
INFO: Executing: /tmp/venv-snappy-proposed-selftest-agent4imbz5zi/bin/python3 setup.py test
INFO: Executing: /tmp/venv-snappy-proposed-selftest-agent4imbz5zi/bin/python3 setup.py flake8
ERROR: Calling `['/tmp/venv-snappy-proposed-selftest-agent4imbz5zi/bin/python3', 'setup.py', 'flake8']` failed (with code 1)

Branched 8 revisions.
test_can_read_message (snappy_proposed_selftest_agent.tests.test_worker.WorkerTests)
snappy_proposed_selftest_agent.tests.test_worker.WorkerTests.test_can_read_message ... ok

----------------------------------------------------------------------
Ran 1 test in 0.026s

OK