Code review comment for lp:~pwlars/lava-test/hwprofile

Revision history for this message
James Westby (james-w) wrote :

On Fri, 06 Aug 2010 20:56:11 -0000, Paul Larson <email address hidden> wrote:
> > Do you want to error if there are fake files but the path isn't in them?
> > That would increase test isolation, but if you intend to read a mix of
> > files then it obviously won't work.
> No, because I could have places where I may want or need to fake one file, but the others are fine to read from the real path.

Ok.

You maybe want to consider a whitelist, but I'm fine with what you have
now.

Thanks,

James

« Back to merge proposal