Merge lp:~pwlars/charms/trusty/snappy-proposed-selftest-agent/rename-snappy-proposed-selftest-agent-charm into lp:~canonical-ci-engineering/charms/trusty/snappy-proposed-selftest-agent/trunk

Proposed by Paul Larson
Status: Merged
Approved by: Paul Larson
Approved revision: 5
Merged at revision: 3
Proposed branch: lp:~pwlars/charms/trusty/snappy-proposed-selftest-agent/rename-snappy-proposed-selftest-agent-charm
Merge into: lp:~canonical-ci-engineering/charms/trusty/snappy-proposed-selftest-agent/trunk
Diff against target: 110 lines (+12/-15)
6 files modified
README (+3/-5)
config.yaml (+1/-1)
hooks/actions.py (+1/-1)
hooks/services.py (+2/-2)
metadata.yaml (+2/-3)
templates/upstart.conf (+3/-3)
To merge this branch: bzr merge lp:~pwlars/charms/trusty/snappy-proposed-selftest-agent/rename-snappy-proposed-selftest-agent-charm
Reviewer Review Type Date Requested Status
Joe Talbott (community) Approve
Paul Larson Needs Resubmitting
Review via email: mp+260301@code.launchpad.net

Commit message

Rename charm to use snappy-proposed-selftest-agent

Description of the change

Rename charm to use snappy-proposed-selftest-agent

To post a comment you must log in.
Revision history for this message
Joe Talbott (joetalbott) wrote :

Looks good to me except for a couple of places where it looks like vim messed up the indentation. Pre-approving assuming you fix those.

review: Approve
4. By Paul Larson

fix whitespace issue

Revision history for this message
Paul Larson (pwlars) wrote :

Fixed

review: Needs Resubmitting
Revision history for this message
Joe Talbott (joetalbott) wrote :

One more.

5. By Paul Larson

one more ws fix

Revision history for this message
Paul Larson (pwlars) wrote :

fixed

review: Needs Resubmitting
Revision history for this message
Joe Talbott (joetalbott) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'README'
--- README 2015-05-27 01:41:42 +0000
+++ README 2015-05-27 15:42:21 +0000
@@ -1,7 +1,7 @@
1Overview1Overview
2--------2--------
33
4This charm installs the core-selftest-agent service.4This charm installs the snappy-proposed-selftest-agent service.
55
6Configuration6Configuration
7-------------7-------------
@@ -9,8 +9,6 @@
9There is only one config option for this charm:9There is only one config option for this charm:
1010
11 * config-file: A base64 encoded string with the config file to use for11 * config-file: A base64 encoded string with the config file to use for
12 core-selftest-agent.12 snappy-proposed-selftest-agent.
1313
14The charm expects the payload code to be provided as 14The charm expects the payload code to be provided as files/snappy-proposed-selftest-agent.tgz (a snapshot of lp:snappy-proposed-selftest-agent) along with its corresponding files/pip-cache directory (python dependencies).
15files/core-selftest-agent.tgz (a snapshot of lp:core-selftest-agent) along
16with its corresponding files/pip-cache directory (python dependencies).
1715
=== modified file 'config.yaml'
--- config.yaml 2015-05-27 01:41:42 +0000
+++ config.yaml 2015-05-27 15:42:21 +0000
@@ -7,5 +7,5 @@
7 config-file:7 config-file:
8 type: string8 type: string
9 description: |9 description: |
10 base64 encoded string with the config file for core-selftest-agent10 base64 encoded string with the config file for snappy-proposed-selftest-agent
1111
1212
=== modified file 'hooks/actions.py'
--- hooks/actions.py 2015-05-27 01:41:42 +0000
+++ hooks/actions.py 2015-05-27 15:42:21 +0000
@@ -7,7 +7,7 @@
7from charmhelpers.core.host import adduser7from charmhelpers.core.host import adduser
8from charmhelpers.payload import (archive, execd)8from charmhelpers.payload import (archive, execd)
99
10SERVICE_NAME = 'core-selftest-agent'10SERVICE_NAME = 'snappy-proposed-selftest-agent'
11SERVICE_CONFIGNAME = 'core-service.conf'11SERVICE_CONFIGNAME = 'core-service.conf'
12REQUIRED_PACKAGES = [12REQUIRED_PACKAGES = [
13 'python-virtualenv', 'python3-dev',13 'python-virtualenv', 'python3-dev',
1414
=== modified file 'hooks/services.py'
--- hooks/services.py 2015-05-27 01:41:42 +0000
+++ hooks/services.py 2015-05-27 15:42:21 +0000
@@ -11,7 +11,7 @@
11 config = hookenv.config()11 config = hookenv.config()
12 manager = ServiceManager([12 manager = ServiceManager([
13 {13 {
14 'service': 'core-selftest-agent',14 'service': 'snappy-proposed-selftest-agent',
15 'required_data': [config],15 'required_data': [config],
16 'data_ready': [16 'data_ready': [
17 actions.basenode,17 actions.basenode,
@@ -22,7 +22,7 @@
22 actions.create_user,22 actions.create_user,
23 helpers.render_template(23 helpers.render_template(
24 source='upstart.conf',24 source='upstart.conf',
25 target='/etc/init/core-selftest-agent.conf'),25 target='/etc/init/snappy-proposed-selftest-agent.conf'),
26 actions.log_start,26 actions.log_start,
27 ],27 ],
28 },28 },
2929
=== modified file 'metadata.yaml'
--- metadata.yaml 2015-05-27 01:41:42 +0000
+++ metadata.yaml 2015-05-27 15:42:21 +0000
@@ -1,8 +1,7 @@
1name: core-selftest-agent1name: snappy-proposed-selftest-agent
2summary: |2summary: |
3 Deploy a service to request tests for new ubuntucore images via3 Deploy a service to request tests for new ubuntucore images via
4 rabbit queue.4 rabbit queue.
5maintainer: Canonical CI Engineering <canonical-ci-engineering@lists.launchpad.net>5maintainer: Canonical CI Engineering <canonical-ci-engineering@lists.launchpad.net>
6description: |6description: |
7 Runs core-selftest-agent service from a given service tarball (provided as7 Runs snappy-proposed-selftest-agent service from a given service tarball (provided as files/snappy-proposed-selftest-agent.tgz).
8 files/core-selftest-agent.tgz).
98
=== modified file 'templates/upstart.conf'
--- templates/upstart.conf 2015-05-27 01:41:42 +0000
+++ templates/upstart.conf 2015-05-27 15:42:21 +0000
@@ -1,4 +1,4 @@
1description "Starts a core-selftest-agent process"1description "Starts a snappy-proposed-selftest-agent process"
22
3start on (local-filesystems and net-device-up IFACE=eth0)3start on (local-filesystems and net-device-up IFACE=eth0)
4stop on runlevel [!12345]4stop on runlevel [!12345]
@@ -11,13 +11,13 @@
11# unless it fails 15 times within 5 seconds11# unless it fails 15 times within 5 seconds
12respawn limit 15 512respawn limit 15 5
1313
14env SERVICE_DIR=/srv/{{ environment }}/core-selftest-agent14env SERVICE_DIR=/srv/{{ environment }}/snappy-proposed-selftest-agent
15env SERVICE_USER=core-worker15env SERVICE_USER=core-worker
1616
17script17script
1818
19 install -d -o ${SERVICE_USER} ${SERVICE_DIR}/logs19 install -d -o ${SERVICE_USER} ${SERVICE_DIR}/logs
20 chdir ${SERVICE_DIR}20 chdir ${SERVICE_DIR}
21 exec sudo -u ${SERVICE_USER} sh -c "./ve/bin/python3 core-selftest-agent.py -c ${SERVICE_DIR}/core-service.conf >> logs/core-selftest-agent.log 2>&1"21 exec sudo -u ${SERVICE_USER} sh -c "./ve/bin/python3 snappy-proposed-selftest-agent.py -c ${SERVICE_DIR}/core-service.conf >> logs/snappy-proposed-selftest-agent.log 2>&1"
2222
23end script23end script

Subscribers

People subscribed via source and target branches