Code review comment for lp:~pwhelan/mixxx/mixxx-pitch_bend

ratecontrol.h:
- Please comment the enums that you have in there. Also, I'd change RATERAMP_OLD to something more descriptive (maybe RATERAMP_STEP instead).
- Please comment the constants you added at the top too. (RATE_TEMP_STEP, RATE_TEMP_STEP_SMALL)

=== modified file 'mixxx/src/mixxxkeyboard.cpp'
--- mixxx/src/mixxxkeyboard.cpp 2009-06-27 22:16:23 +0000
+++ mixxx/src/mixxxkeyboard.cpp 2009-10-26 01:10:25 +0000
@@ -103,7 +103,7 @@
         {
             if (release) {
                 //qDebug() << "Sending MIDI NOTE_OFF";
- ControlObject::getControl(*pConfigKey)->queueFromMidi(NOTE_OFF, 1);
+ ControlObject::getControl(*pConfigKey)->queueFromMidi(NOTE_OFF, 0);
             }
             else
             {
-----> What is this change?

Re: EngineBufferScaleLinear - I looked at your changes and I don't see anything immediately wrong. We're going to have to make sure we test the hell out of this though before our beta. :)

Re: The "Pitchbend sensitivity" label in the preferences. I think this label is misleading because higher sensitivity usually means faster response, but turning up the sensitivity slider seems to actually slow down the ramping. Can you flip your slider values around or something?

Awesome stuff Phil! I think ramping pitchbend is way easier to mix with and is more intuitive to use than the weirdo stepped stuff we had before.

See if you can fix these things up and then I think we're ready to merge.

Thanks!
Albert