Code review comment for ~pushkarnk/ubuntu/+source/python-trio:fix-2054772
Revision history for this message
| Pushkar Kulkarni (pushkarnk) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
a60fb26
(Get the code!)
> This looks good code-wise. Just a few organizational comments:
>
> 1. Can you please squash your fixup commits into "Add patch to avoid
> PermissioErrors on LP"? This keeps the history cleaner.
> 2. Please update both the patch Description: field, and the changelog entry to
> reflect that you are catching and ignoring the exception. The current language
> used suggests the code is still commented out, which is not true.
>
> After that is fixed I will upload this. Thanks!
Thanks, the commit history was looking very bad indeed. Fixed now.