Ubuntu
python-trio package

Code review comment for ~pushkarnk/ubuntu/+source/python-trio:fix-2054772

  1. Git
  2. lp:~pushkarnk/ubuntu/+source/python-trio
  3. fix-2054772
  4. Merge into ubuntu/devel
Revision history for this message
Nick Rosbrook (enr0n) wrote :

This looks good code-wise. Just a few organizational comments:

1. Can you please squash your fixup commits into "Add patch to avoid PermissioErrors on LP"? This keeps the history cleaner.
2. Please update both the patch Description: field, and the changelog entry to reflect that you are catching and ignoring the exception. The current language used suggests the code is still commented out, which is not true.

After that is fixed I will upload this. Thanks!

review: Needs Fixing

« Back to merge proposal