Code review comment for ~pushkarnk/ubuntu/+source/pgpainless:fix-2044109

Revision history for this message
Vladimir Petko (vpa1977) wrote :

Some minor comments:

- Closes: #XXXX tag applies to debian MPs. In Ubuntu the tag is LP: #xxxx
- The patch is not strictly necessary, we can append ' --exclude-classname=investigations.KleopatraCompatibilityTest' to JUNIT_OPTIONS in debian/rules to exclude the class from testing. This also might make it easier to submit to debian and reduce maintenance effort for the next release.

You will need a reviewer with upload rights, so I am marking this review as 'Abstain'

review: Abstain

« Back to merge proposal