Code review comment for lp:~pundiramit/linaro-android-build-tools/access_private_manifests

Revision history for this message
Данило Шеган (danilo) wrote :

Does it not make sense to read ID from some environment variable as well? (so people can simply set it in their .bashrc or .profile to ensure the same ID is used going forward)

Of course, if you make it an environment variable, I suppose naming it like LINARO_ANDROID_ACCESS_ID would be better than just "ID".

Btw, what are the reasons to replace ".*-bot" with ${ID}, and not simply replace "default-bot"?

review: Needs Fixing

« Back to merge proposal