Merge lp:~pskoli93/postorius/Redirection-Fixes into lp:postorius

Proposed by Pavan Koli
Status: Needs review
Proposed branch: lp:~pskoli93/postorius/Redirection-Fixes
Merge into: lp:postorius
Diff against target: 16 lines (+4/-2)
1 file modified
src/postorius/views/list.py (+4/-2)
To merge this branch: bzr merge lp:~pskoli93/postorius/Redirection-Fixes
Reviewer Review Type Date Requested Status
Mailman Coders Pending
Review via email: mp+257457@code.launchpad.net

Description of the change

There are some redirection issues during unsubscription, suppose we want to unsubscribe a member if we click on unsubscribe button present on the list_members page then we are redirected to list_summary page instead we should be redirected to the list_members page.

So we have to check the email if it is equal to request.user.email, then we should redirect to list_summary page else redirect to list_members page.

To post a comment you must log in.

Unmerged revisions

248. By pkoli <email address hidden>

Redirection Fixes

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/postorius/views/list.py'
--- src/postorius/views/list.py 2015-04-17 21:51:29 +0000
+++ src/postorius/views/list.py 2015-04-25 09:41:16 +0000
@@ -306,8 +306,10 @@
306 return utils.render_api_error(request)306 return utils.render_api_error(request)
307 except ValueError, e:307 except ValueError, e:
308 messages.error(request, e)308 messages.error(request, e)
309 return redirect('list_summary', self.mailing_list.list_id)309 if(email == request.user.email):
310310 return redirect('list_summary', self.mailing_list.list_id)
311 else:
312 return redirect('list_members', self.mailing_list.list_id)
311313
312class ListMassSubscribeView(MailingListView):314class ListMassSubscribeView(MailingListView):
313 """Mass subscription."""315 """Mass subscription."""

Subscribers

People subscribed via source and target branches