Postorius

Merge lp:~pskoli93/postorius/More_info_Fixes into lp:postorius

  1. More_info_Fixes
  2. Merge into trunk
Proposed by Pavan Koli
Status: Needs review
Proposed branch: lp:~pskoli93/postorius/More_info_Fixes
Merge into: lp:postorius
Diff against target: 128 lines (+13/-13)
3 files modified
src/postorius/templates/postorius/user_address_preferences.html (+6/-6)
src/postorius/templates/postorius/user_mailmansettings.html (+6/-6)
src/postorius/templates/postorius/user_subscription_preferences.html (+1/-1)
To merge this branch: bzr merge lp:~pskoli93/postorius/More_info_Fixes
Reviewer Review Type Date Requested Status
Mailman Coders Pending
Review via email: mp+257923@code.launchpad.net

Description of the change

If go to My settings. There if you click on More info option, it just opens a new tab. Fix has removed the associated anchor text.

To post a comment you must log in.
lp:~pskoli93/postorius/More_info_Fixes updated
250. By pkoli <email address hidden>

More info Fixes

Unmerged revisions

250. By pkoli <email address hidden>

More info Fixes

249. By pkoli <email address hidden>

More info Fixes

248. By pkoli <email address hidden>

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/postorius/templates/postorius/user_address_preferences.html'
--- src/postorius/templates/postorius/user_address_preferences.html 2015-04-15 00:43:21 +0000
+++ src/postorius/templates/postorius/user_address_preferences.html 2015-04-30 16:43:34 +0000
@@ -36,7 +36,7 @@
36 <tr>36 <tr>
37 <td>37 <td>
38 <p>{% trans 'Mail Delivery' %}: </p>38 <p>{% trans 'Mail Delivery' %}: </p>
39 <p>[<span class="more_info"><a href="#" target="_blank">{% trans 'More info' %}</a><span>{{ helperform.delivery_status.help_text }}39 <p>[<span class="more_info">{% trans 'More info' %}<span>{{ helperform.delivery_status.help_text }}
40 </span></span>] 40 </span></span>]
41 </p>41 </p>
42 </td>42 </td>
@@ -47,7 +47,7 @@
47 <tr>47 <tr>
48 <td>48 <td>
49 <p> {% trans 'Select a Mode of Delivery' %}: </p>49 <p> {% trans 'Select a Mode of Delivery' %}: </p>
50 <p>[<span class="more_info"><a href="#" target="_blank">{% trans 'More info' %}</a><span>{{ helperform.delivery_mode.help_text }}50 <p>[<span class="more_info">{% trans 'More info' %}<span>{{ helperform.delivery_mode.help_text }}
51 </span></span>] 51 </span></span>]
52 </p>52 </p>
53 </td>53 </td>
@@ -58,7 +58,7 @@
58 <tr>58 <tr>
59 <td>59 <td>
60 <p> {% trans 'Receive your own posts to the list?' %} </p>60 <p> {% trans 'Receive your own posts to the list?' %} </p>
61 <p>[<span class="more_info"><a href="#" target="_blank">{% trans 'More info' %}</a><span>{{ helperform.receive_own_postings.help_text }}61 <p>[<span class="more_info">{% trans 'More info' %}<span>{{ helperform.receive_own_postings.help_text }}
62 </span></span>] 62 </span></span>]
63 </p>63 </p>
64 </td>64 </td>
@@ -69,7 +69,7 @@
69 <tr>69 <tr>
70 <td>70 <td>
71 <p> {% trans 'Receive acknowledgement mails?' %} </p>71 <p> {% trans 'Receive acknowledgement mails?' %} </p>
72 <p>[<span class="more_info"><a href="#" target="_blank">{% trans 'More info' %}</a><span>{{ helperform.acknowledge_posts.help_text }}72 <p>[<span class="more_info">{% trans 'More info' %}<span>{{ helperform.acknowledge_posts.help_text }}
73 </span></span>]73 </span></span>]
74 </p>74 </p>
75 </td>75 </td>
@@ -80,7 +80,7 @@
80 <tr>80 <tr>
81 <td>81 <td>
82 <p> {% trans 'Conceal yourself from the subscriber list?' %} </p>82 <p> {% trans 'Conceal yourself from the subscriber list?' %} </p>
83 <p>[<span class="more_info"><a href="#" target="_blank">{% trans 'More info' %}</a><span>{{ helperform.hide_address.help_text }}83 <p>[<span class="more_info">{% trans 'More info' %}<span>{{ helperform.hide_address.help_text }}
84 </span></span>]84 </span></span>]
85 </p>85 </p>
86 </td>86 </td>
@@ -91,7 +91,7 @@
91 <tr>91 <tr>
92 <td>92 <td>
93 <p> {% trans 'Avoid duplicate copies of messages?' %} </p>93 <p> {% trans 'Avoid duplicate copies of messages?' %} </p>
94 <p>[<span class="more_info"><a href="#" target="_blank">{% trans 'More info' %}</a><span>{{ helperform.receive_list_copy.help_text }}94 <p>[<span class="more_info">{% trans 'More info' %}<span>{{ helperform.receive_list_copy.help_text }}
95 </span></span>]95 </span></span>]
96 </p>96 </p>
97 </td>97 </td>
9898
=== modified file 'src/postorius/templates/postorius/user_mailmansettings.html'
--- src/postorius/templates/postorius/user_mailmansettings.html 2015-04-16 01:56:51 +0000
+++ src/postorius/templates/postorius/user_mailmansettings.html 2015-04-30 16:43:34 +0000
@@ -32,7 +32,7 @@
32 <td>32 <td>
33 <p> {% trans "Mail Delivery" %}: </p>33 <p> {% trans "Mail Delivery" %}: </p>
34 </p>34 </p>
35 [<span class="more_info"><a href="#" target="_blank">{% trans 'More info' %}</a><span>{{ settingsform.delivery_status.help_text }}35 [<span class="more_info">{% trans 'More info' %}<span>{{ settingsform.delivery_status.help_text }}
36 </span></span>] </p>36 </span></span>] </p>
37 </td>37 </td>
38 <td> {{settingsform.delivery_status }} </td>38 <td> {{settingsform.delivery_status }} </td>
@@ -41,7 +41,7 @@
41 <td>41 <td>
42 <p> {% trans "Select a Mode of Delivery" %}: </p>42 <p> {% trans "Select a Mode of Delivery" %}: </p>
43 </p>43 </p>
44 [<span class="more_info"><a href="#" target="_blank">{% trans 'More info' %}</a><span>{{ settingsform.delivery_mode.help_text }}44 [<span class="more_info">{% trans 'More info' %}<span>{{ settingsform.delivery_mode.help_text }}
45 </span></span>] </p>45 </span></span>] </p>
46 </td>46 </td>
47 <td> {{settingsform.delivery_mode }} </td>47 <td> {{settingsform.delivery_mode }} </td>
@@ -50,7 +50,7 @@
50 <td>50 <td>
51 <p> {% trans "Receive your own posts to the list?" %} </p>51 <p> {% trans "Receive your own posts to the list?" %} </p>
52 </p>52 </p>
53 [<span class="more_info"><a href="#" target="_blank">{% trans 'More info' %}</a><span>{{ settingsform.receive_own_postings.help_text }}53 [<span class="more_info">{% trans 'More info' %}<span>{{ settingsform.receive_own_postings.help_text }}
54 </span></span>] </p>54 </span></span>] </p>
55 </td>55 </td>
56 <td> {{settingsform.receive_own_postings }} </td>56 <td> {{settingsform.receive_own_postings }} </td>
@@ -59,7 +59,7 @@
59 <td>59 <td>
60 <p> {% trans "Receive acknowledgement mails?" %} </p>60 <p> {% trans "Receive acknowledgement mails?" %} </p>
61 </p>61 </p>
62 [<span class="more_info"><a href="#" target="_blank">{% trans 'More info' %}</a><span>{{ settingsform.acknowledge_posts.help_text }}62 [<span class="more_info">{% trans 'More info' %}<span>{{ settingsform.acknowledge_posts.help_text }}
63 </span></span>] </p>63 </span></span>] </p>
64 </td>64 </td>
65 <td> {{settingsform.acknowledge_posts }} </td>65 <td> {{settingsform.acknowledge_posts }} </td>
@@ -68,7 +68,7 @@
68 <td>68 <td>
69 <p>{% trans "Conceal yourself from the subscriber list?" %} </p>69 <p>{% trans "Conceal yourself from the subscriber list?" %} </p>
70 </p>70 </p>
71 [<span class="more_info"><a href="#" target="_blank">{% trans 'More info' %}</a><span>{{ settingsform.hide_address.help_text }}71 [<span class="more_info">{% trans 'More info' %}<span>{{ settingsform.hide_address.help_text }}
72 </span></span>] </p>72 </span></span>] </p>
73 </td>73 </td>
74 <td> {{settingsform.hide_address }} </td>74 <td> {{settingsform.hide_address }} </td>
@@ -76,7 +76,7 @@
76 <tr>76 <tr>
77 <td>77 <td>
78 <p>{% trans "Avoid duplicate copies of messages?" %}</p>78 <p>{% trans "Avoid duplicate copies of messages?" %}</p>
79 </p> [<span class="more_info"><a href="#" target="_blank">{% trans 'More info' %}</a><span>{{ settingsform.receive_list_copy.help_text }}79 </p> [<span class="more_info">{% trans 'More info' %}<span>{{ settingsform.receive_list_copy.help_text }}
80 </span></span>] </p>80 </span></span>] </p>
81 </td>81 </td>
82 <td> {{settingsform.receive_list_copy }} </td>82 <td> {{settingsform.receive_list_copy }} </td>
8383
=== modified file 'src/postorius/templates/postorius/user_subscription_preferences.html'
--- src/postorius/templates/postorius/user_subscription_preferences.html 2015-04-15 00:43:21 +0000
+++ src/postorius/templates/postorius/user_subscription_preferences.html 2015-04-30 16:43:34 +0000
@@ -30,7 +30,7 @@
30 <tr>30 <tr>
31 <th> {% trans 'Subscription' %} </th>31 <th> {% trans 'Subscription' %} </th>
32 {% for field in form.visible_fields %}32 {% for field in form.visible_fields %}
33 <th>{{field.label}} <p><span class="more_info">[<a href="#" target="_blank">{% trans 'More info' %}</a><span>{{ field.help_text }}33 <th>{{field.label}} <p><span class="more_info">[{% trans 'More info' %}<span>{{ field.help_text }}
34 </span>]</span></p></th>34 </span>]</span></p></th>
35 {% endfor %}35 {% endfor %}
36 </tr >36 </tr >

Subscribers

People subscribed via source and target branches