Postorius

Merge lp:~pskoli93/postorius/More_info_Fixes into lp:postorius

  1. More_info_Fixes
  2. Merge into trunk
Proposed by Pavan Koli
Status: Needs review
Proposed branch: lp:~pskoli93/postorius/More_info_Fixes
Merge into: lp:postorius
Diff against target: 128 lines (+13/-13)
3 files modified
src/postorius/templates/postorius/user_address_preferences.html (+6/-6)
src/postorius/templates/postorius/user_mailmansettings.html (+6/-6)
src/postorius/templates/postorius/user_subscription_preferences.html (+1/-1)
To merge this branch: bzr merge lp:~pskoli93/postorius/More_info_Fixes
Reviewer Review Type Date Requested Status
Mailman Coders Pending
Review via email: mp+257923@code.launchpad.net

Description of the change

If go to My settings. There if you click on More info option, it just opens a new tab. Fix has removed the associated anchor text.

To post a comment you must log in.
lp:~pskoli93/postorius/More_info_Fixes updated
250. By pkoli <email address hidden>

More info Fixes

Unmerged revisions

250. By pkoli <email address hidden>

More info Fixes

249. By pkoli <email address hidden>

More info Fixes

248. By pkoli <email address hidden>

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/postorius/templates/postorius/user_address_preferences.html'
2--- src/postorius/templates/postorius/user_address_preferences.html 2015-04-15 00:43:21 +0000
3+++ src/postorius/templates/postorius/user_address_preferences.html 2015-04-30 16:43:34 +0000
4@@ -36,7 +36,7 @@
5 <tr>
6 <td>
7 <p>{% trans 'Mail Delivery' %}: </p>
8- <p>[<span class="more_info"><a href="#" target="_blank">{% trans 'More info' %}</a><span>{{ helperform.delivery_status.help_text }}
9+ <p>[<span class="more_info">{% trans 'More info' %}<span>{{ helperform.delivery_status.help_text }}
10 </span></span>]
11 </p>
12 </td>
13@@ -47,7 +47,7 @@
14 <tr>
15 <td>
16 <p> {% trans 'Select a Mode of Delivery' %}: </p>
17- <p>[<span class="more_info"><a href="#" target="_blank">{% trans 'More info' %}</a><span>{{ helperform.delivery_mode.help_text }}
18+ <p>[<span class="more_info">{% trans 'More info' %}<span>{{ helperform.delivery_mode.help_text }}
19 </span></span>]
20 </p>
21 </td>
22@@ -58,7 +58,7 @@
23 <tr>
24 <td>
25 <p> {% trans 'Receive your own posts to the list?' %} </p>
26- <p>[<span class="more_info"><a href="#" target="_blank">{% trans 'More info' %}</a><span>{{ helperform.receive_own_postings.help_text }}
27+ <p>[<span class="more_info">{% trans 'More info' %}<span>{{ helperform.receive_own_postings.help_text }}
28 </span></span>]
29 </p>
30 </td>
31@@ -69,7 +69,7 @@
32 <tr>
33 <td>
34 <p> {% trans 'Receive acknowledgement mails?' %} </p>
35- <p>[<span class="more_info"><a href="#" target="_blank">{% trans 'More info' %}</a><span>{{ helperform.acknowledge_posts.help_text }}
36+ <p>[<span class="more_info">{% trans 'More info' %}<span>{{ helperform.acknowledge_posts.help_text }}
37 </span></span>]
38 </p>
39 </td>
40@@ -80,7 +80,7 @@
41 <tr>
42 <td>
43 <p> {% trans 'Conceal yourself from the subscriber list?' %} </p>
44- <p>[<span class="more_info"><a href="#" target="_blank">{% trans 'More info' %}</a><span>{{ helperform.hide_address.help_text }}
45+ <p>[<span class="more_info">{% trans 'More info' %}<span>{{ helperform.hide_address.help_text }}
46 </span></span>]
47 </p>
48 </td>
49@@ -91,7 +91,7 @@
50 <tr>
51 <td>
52 <p> {% trans 'Avoid duplicate copies of messages?' %} </p>
53- <p>[<span class="more_info"><a href="#" target="_blank">{% trans 'More info' %}</a><span>{{ helperform.receive_list_copy.help_text }}
54+ <p>[<span class="more_info">{% trans 'More info' %}<span>{{ helperform.receive_list_copy.help_text }}
55 </span></span>]
56 </p>
57 </td>
58
59=== modified file 'src/postorius/templates/postorius/user_mailmansettings.html'
60--- src/postorius/templates/postorius/user_mailmansettings.html 2015-04-16 01:56:51 +0000
61+++ src/postorius/templates/postorius/user_mailmansettings.html 2015-04-30 16:43:34 +0000
62@@ -32,7 +32,7 @@
63 <td>
64 <p> {% trans "Mail Delivery" %}: </p>
65 </p>
66- [<span class="more_info"><a href="#" target="_blank">{% trans 'More info' %}</a><span>{{ settingsform.delivery_status.help_text }}
67+ [<span class="more_info">{% trans 'More info' %}<span>{{ settingsform.delivery_status.help_text }}
68 </span></span>] </p>
69 </td>
70 <td> {{settingsform.delivery_status }} </td>
71@@ -41,7 +41,7 @@
72 <td>
73 <p> {% trans "Select a Mode of Delivery" %}: </p>
74 </p>
75- [<span class="more_info"><a href="#" target="_blank">{% trans 'More info' %}</a><span>{{ settingsform.delivery_mode.help_text }}
76+ [<span class="more_info">{% trans 'More info' %}<span>{{ settingsform.delivery_mode.help_text }}
77 </span></span>] </p>
78 </td>
79 <td> {{settingsform.delivery_mode }} </td>
80@@ -50,7 +50,7 @@
81 <td>
82 <p> {% trans "Receive your own posts to the list?" %} </p>
83 </p>
84- [<span class="more_info"><a href="#" target="_blank">{% trans 'More info' %}</a><span>{{ settingsform.receive_own_postings.help_text }}
85+ [<span class="more_info">{% trans 'More info' %}<span>{{ settingsform.receive_own_postings.help_text }}
86 </span></span>] </p>
87 </td>
88 <td> {{settingsform.receive_own_postings }} </td>
89@@ -59,7 +59,7 @@
90 <td>
91 <p> {% trans "Receive acknowledgement mails?" %} </p>
92 </p>
93- [<span class="more_info"><a href="#" target="_blank">{% trans 'More info' %}</a><span>{{ settingsform.acknowledge_posts.help_text }}
94+ [<span class="more_info">{% trans 'More info' %}<span>{{ settingsform.acknowledge_posts.help_text }}
95 </span></span>] </p>
96 </td>
97 <td> {{settingsform.acknowledge_posts }} </td>
98@@ -68,7 +68,7 @@
99 <td>
100 <p>{% trans "Conceal yourself from the subscriber list?" %} </p>
101 </p>
102- [<span class="more_info"><a href="#" target="_blank">{% trans 'More info' %}</a><span>{{ settingsform.hide_address.help_text }}
103+ [<span class="more_info">{% trans 'More info' %}<span>{{ settingsform.hide_address.help_text }}
104 </span></span>] </p>
105 </td>
106 <td> {{settingsform.hide_address }} </td>
107@@ -76,7 +76,7 @@
108 <tr>
109 <td>
110 <p>{% trans "Avoid duplicate copies of messages?" %}</p>
111- </p> [<span class="more_info"><a href="#" target="_blank">{% trans 'More info' %}</a><span>{{ settingsform.receive_list_copy.help_text }}
112+ </p> [<span class="more_info">{% trans 'More info' %}<span>{{ settingsform.receive_list_copy.help_text }}
113 </span></span>] </p>
114 </td>
115 <td> {{settingsform.receive_list_copy }} </td>
116
117=== modified file 'src/postorius/templates/postorius/user_subscription_preferences.html'
118--- src/postorius/templates/postorius/user_subscription_preferences.html 2015-04-15 00:43:21 +0000
119+++ src/postorius/templates/postorius/user_subscription_preferences.html 2015-04-30 16:43:34 +0000
120@@ -30,7 +30,7 @@
121 <tr>
122 <th> {% trans 'Subscription' %} </th>
123 {% for field in form.visible_fields %}
124- <th>{{field.label}} <p><span class="more_info">[<a href="#" target="_blank">{% trans 'More info' %}</a><span>{{ field.help_text }}
125+ <th>{{field.label}} <p><span class="more_info">[{% trans 'More info' %}<span>{{ field.help_text }}
126 </span>]</span></p></th>
127 {% endfor %}
128 </tr >

Subscribers

People subscribed via source and target branches