Some minor nitpicks:
41 + self.fail("Failed to fetch problems.html from the server")
You have an extra space after "from"
pep8 issues (easy cleanups, but since I just pushed a branch cleaning things like this, seems appropriate not to introduce more)
iso_static_validation.py:107:1: W293 blank line contains whitespace
iso_static_validation.py:108:80: E501 line too long (88 characters)
iso_static_validation.py:112:5: E301 expected 1 blank line, found 0
iso_static_validation.py:399:46: E231 missing whitespace after ','
For bonus points, it's a good habit to start coding things in a way that are python3 compliant. So things like exception handling should be, for example:
except urllib2.HTTPError as e:
If you'd like though, just fix the pep8 stuff and we can do the python3 compliance as another fix later on. It's not really a requirement right now, but would be a good idea considering the future direction of python.
Good!
19 + join(ARCHIVE_ TEST_URL, self.st_release + '_probs.html') join(ARCHIVE_ TEST_URL, self.st_release + '_probs.html')
20 + self.probs_url = os.path.
21
22 + self.probs_url = os.path.
Duplicate line?
Some minor nitpicks:
41 + self.fail("Failed to fetch problems.html from the server")
You have an extra space after "from"
pep8 issues (easy cleanups, but since I just pushed a branch cleaning things like this, seems appropriate not to introduce more) validation. py:107: 1: W293 blank line contains whitespace validation. py:108: 80: E501 line too long (88 characters) validation. py:112: 5: E301 expected 1 blank line, found 0 validation. py:399: 46: E231 missing whitespace after ','
iso_static_
iso_static_
iso_static_
iso_static_
For bonus points, it's a good habit to start coding things in a way that are python3 compliant. So things like exception handling should be, for example:
except urllib2.HTTPError as e:
If you'd like though, just fix the pep8 stuff and we can do the python3 compliance as another fix later on. It's not really a requirement right now, but would be a good idea considering the future direction of python.