Code review comment for lp:~psivaa/charms/precise/ubuntu-ci-services-itself/upstart-with-proxy-2

Revision history for this message
Andy Doan (doanac) wrote :

You should be able to keep this diff smaller with jinja2 conditional logic like:

{% if proxy_url %}
env http_proxy={proxy_url}
env https_proxy={proxy_url}
{% endif %}

Then you won't need those two big blocks that are essentially the same logic

review: Needs Fixing

« Back to merge proposal