Merge ~przemeklal/juju-lint:add-charm-local-users into juju-lint:master

Proposed by Przemyslaw Lal
Status: Merged
Approved by: James Troup
Approved revision: 054d6eae4415605d759edf11d026892bb66bbf56
Merged at revision: c536c3a12e76a4d921ee41a35ad65f6aa69bd12c
Proposed branch: ~przemeklal/juju-lint:add-charm-local-users
Merge into: juju-lint:master
Diff against target: 43 lines (+6/-0)
3 files modified
contrib/canonical-rules.yaml (+3/-0)
contrib/includes/base.yaml (+2/-0)
contrib/includes/operations.yaml (+1/-0)
Reviewer Review Type Date Requested Status
Juju Lint maintainers Pending
BootStack Reviewers Pending
Review via email: mp+412693@code.launchpad.net

Commit message

Add local-users charm

Add local-users as an optional subordinate operations charm.
Set the rule to "where: all or nothing" - if deployed anywhere, must
be deployed everywhere.

Signed-off-by: Przemysław Lal <email address hidden>

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision c536c3a12e76a4d921ee41a35ad65f6aa69bd12c

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/contrib/canonical-rules.yaml b/contrib/canonical-rules.yaml
2index b655f34..9056390 100644
3--- a/contrib/canonical-rules.yaml
4+++ b/contrib/canonical-rules.yaml
5@@ -91,6 +91,8 @@ subordinates:
6 where: host only
7 logrotated:
8 where: all
9+ local-users:
10+ where: all or nothing
11
12 kubernetes mandatory: &kubernetes-mandatory-charms
13 - containerd
14@@ -155,6 +157,7 @@ operations optional subordinates: &operations-optional-subs
15 - logrotate-charm
16 - advanced-routing
17 - rsyslog-forwarder-ha
18+ - local-users
19
20 operations charms: &operations-charms
21 - *operations-kubernetes-mandatory-charms
22diff --git a/contrib/includes/base.yaml b/contrib/includes/base.yaml
23index d8063eb..0e171e3 100644
24--- a/contrib/includes/base.yaml
25+++ b/contrib/includes/base.yaml
26@@ -41,3 +41,5 @@ subordinates:
27 where: metal only
28 logrotated:
29 where: all
30+ local-users:
31+ where: all or nothing
32diff --git a/contrib/includes/operations.yaml b/contrib/includes/operations.yaml
33index 40b628b..736ce11 100644
34--- a/contrib/includes/operations.yaml
35+++ b/contrib/includes/operations.yaml
36@@ -44,6 +44,7 @@ operations optional subordinates: &operations-optional-subs
37 - logrotate-charm
38 - advanced-routing
39 - rsyslog-forwarder-ha
40+ - local-users
41
42 operations kubernetes mandatory: &operations-kubernetes-mandatory-charms
43 - kubernetes-service-checks

Subscribers

People subscribed via source and target branches