lp:wmaker

Created by Doug Torrance and last modified
Get this branch:
bzr branch lp:wmaker

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
Doug Torrance
Project:
Window Maker
Status:
Development

Import details

Import Status: Reviewed

This branch is an import of the HEAD branch of the Git repository at git://repo.or.cz/wmaker-crm.git,branch=next.

The next import is scheduled to run .

Last successful import was .

Import started on alnitak and finished taking 10 seconds — see the log
Import started on izar and finished taking 10 seconds — see the log
Import started on izar and finished taking 10 seconds — see the log
Import started on alnitak and finished taking 10 seconds — see the log
Import started on izar and finished taking 10 seconds — see the log
Import started on alnitak and finished taking 10 seconds — see the log
Import started on izar and finished taking 10 seconds — see the log
Import started on alnitak and finished taking 10 seconds — see the log
Import started on alnitak and finished taking 10 seconds — see the log
Import started on izar and finished taking 10 seconds — see the log

Recent revisions

3757. By Lobotomy 22 hours ago

WPrefs: Fix memory leak in Expert tab

As reported by Coverity (CID #331553), we leak the allocated string
returned by 'WMGetTextFieldText'

Signed-off-by: Christophe CURIS <email address hidden>

3756. By Lobotomy 22 hours ago

WPrefs: Fix memory leak in the Menu tab

As reported by Coverity (CID #331559), the call to 'wfindfile' replaces
the value for variable 'path' but we did not free its previous content.

Signed-off-by: Christophe CURIS <email address hidden>

3755. By Lobotomy 22 hours ago

Fix use-after-free error in wIconStore reported by Coverity

The function always returns the filename where the icon have been saved,
but in the case where the save operation failed we would free the memory
for that file name, yet still return this pointer like if it were valid.

Took opportunity to remove redundant free(path) which is done a couple
lines later, because redundancy is a source of problem for code
maintenance.

Signed-off-by: Christophe CURIS <email address hidden>

3754. By Lobotomy 22 hours ago

Fix memory leak reported by Coverity

As reported in CID #331577, we re-use the variable 'tmp' without freeing
the previously allocated pointer.

Signed-off-by: Christophe CURIS <email address hidden>

3753. By Lobotomy 22 hours ago

WPrefs: fix memory leak and potential buffer overflow

Coverity pointed that the "text" returned by WMGetTextFieldText was never
freed (CID #331578, because WMSetTextFieldText does its own copy, it does
not take the pointer as-is).

By looking at the code, there is also a potential buffer overflow because
the buffer alloc'd for "value" is sized for the exact number of digits
before increase, but the +delta can make the number use more digits so we
may write past the end of original buffer.
We write to a stack-allocated one, so it does not cost anything and does
not participates to memory fragmentation.

Signed-off-by: Christophe CURIS <email address hidden>

3752. By Lobotomy on 2021-05-14

WINGs: Fix invalid handling of Blue in the HSV conversion in ColorPanel widget

Because of a minor bug, when pure blue was chosen in RGB in the ColorPanel,
the conversion to HSV would mistreat it as white and resets its hue,
leading to possible user annoyance.

3751. By Lobotomy on 2021-05-14

WINGs: increase temporary buffer to silence a gcc warning

The code limits the integer number to 0..359 so we need 4 bytes to store
that, but that require too complex flow processing for compilers to deduce
it.

It does not cost to increase the temporary buffer to the minimum size
requested by GCC, so let's do this, because spurious warnings can
potentially divert us from more important ones.

Signed-off-by: Christophe CURIS <email address hidden>

3750. By Lobotomy on 2021-05-14

wraster: Remove duplicate code

Duplicating things makes maintenance error-prone, which is not a good idea.
In case the abort procedure would need an update, it would be easy then
to forget some place, leading to leaks, if not worse.

Beside, goto is not as bad as academics would like people to believe, when
it is used correctly (and this case is one of them).
The name for the label was given an explicit meaning to make code easy to
understand.

Signed-off-by: Christophe CURIS <email address hidden>

3749. By Lobotomy on 2021-05-14

Fix usage of float constant reported by gcc

Signed-off-by: Christophe CURIS <email address hidden>

3748. By Lobotomy on 2021-05-14

WINGs: Fix incorrect use of macro USE_PANGO in installed header

The header "WINGsP.h" needs different behaviour depending on whether the
support for Pango was enabled or not. But the related macro USE_PANGO is
defined by WindowMaker's configure, and after this header have been
installed the macro is no more valid.

This patch makes the "WINGsP.h" a generated file, so it will be different
depending on USE_PANGO, but will not make use of the macro itself.

As a side effect of being now generated, the include paths in the makefile
have been updated to include build-dir too, because for users doing an
out-of-tree build the generated file (that is used during compilation) is
placed in the build-dir.

Signed-off-by: Christophe CURIS <email address hidden>

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
This branch contains Public information 
Everyone can see this information.

Subscribers