Merge lp:~profzoom/ubuntu/vivid/unity-greeter-badges/bump-to-0.4 into lp:ubuntu/vivid/unity-greeter-badges

Proposed by Doug Torrance
Status: Approved
Approved by: Graham Inggs
Approved revision: 4
Proposed branch: lp:~profzoom/ubuntu/vivid/unity-greeter-badges/bump-to-0.4
Merge into: lp:ubuntu/vivid/unity-greeter-badges
Diff against target: 170 lines (+47/-62)
4 files modified
debian/changelog (+17/-0)
debian/control (+1/-1)
debian/install (+2/-61)
debian/rules (+27/-0)
To merge this branch: bzr merge lp:~profzoom/ubuntu/vivid/unity-greeter-badges/bump-to-0.4
Reviewer Review Type Date Requested Status
Graham Inggs Approve
Review via email: mp+251365@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Graham Inggs (ginggs) :
review: Approve

Unmerged revisions

4. By Doug Torrance

* New upstream release.
* debian/install
  - Simplify file to use wildcard. We will handle the special cases
    in debian/rules.
  - Remove executable bit; not needed since we no longer use dh-exec.
* debian/control
  - Remove dh-exec from Build-Depends; no longer needed.
* debian/rules
  - Add override_dh_install target to remove badges found in other packages
    and fix resulting broken symlinks. This function was previously
    performed by dh-exec using debian/install, but this was harder to
    maintain.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== added symlink 'custom_QLubuntu_badge.png'
=== target is u'custom_LXDE_badge.png'
=== added file 'custom_aewm++_badge.png'
0Binary files custom_aewm++_badge.png 1970-01-01 00:00:00 +0000 and custom_aewm++_badge.png 2015-02-28 14:28:23 +0000 differ0Binary files custom_aewm++_badge.png 1970-01-01 00:00:00 +0000 and custom_aewm++_badge.png 2015-02-28 14:28:23 +0000 differ
=== added file 'custom_cde_badge.png'
1Binary files custom_cde_badge.png 1970-01-01 00:00:00 +0000 and custom_cde_badge.png 2015-02-28 14:28:23 +0000 differ1Binary files custom_cde_badge.png 1970-01-01 00:00:00 +0000 and custom_cde_badge.png 2015-02-28 14:28:23 +0000 differ
=== added file 'custom_deepin_badge.png'
2Binary files custom_deepin_badge.png 1970-01-01 00:00:00 +0000 and custom_deepin_badge.png 2015-02-28 14:28:23 +0000 differ2Binary files custom_deepin_badge.png 1970-01-01 00:00:00 +0000 and custom_deepin_badge.png 2015-02-28 14:28:23 +0000 differ
=== added file 'custom_ede_badge.png'
3Binary files custom_ede_badge.png 1970-01-01 00:00:00 +0000 and custom_ede_badge.png 2015-02-28 14:28:23 +0000 differ3Binary files custom_ede_badge.png 1970-01-01 00:00:00 +0000 and custom_ede_badge.png 2015-02-28 14:28:23 +0000 differ
=== added file 'custom_gnome-bluetile_badge.png'
4Binary files custom_gnome-bluetile_badge.png 1970-01-01 00:00:00 +0000 and custom_gnome-bluetile_badge.png 2015-02-28 14:28:23 +0000 differ4Binary files custom_gnome-bluetile_badge.png 1970-01-01 00:00:00 +0000 and custom_gnome-bluetile_badge.png 2015-02-28 14:28:23 +0000 differ
=== added symlink 'custom_lubuntu-nexus7_badge.png'
=== target is u'custom_LXDE_badge.png'
=== added symlink 'custom_lxgames_badge.png'
=== target is u'custom_LXDE_badge.png'
=== added file 'custom_matchbox_badge.png'
5Binary files custom_matchbox_badge.png 1970-01-01 00:00:00 +0000 and custom_matchbox_badge.png 2015-02-28 14:28:23 +0000 differ5Binary files custom_matchbox_badge.png 1970-01-01 00:00:00 +0000 and custom_matchbox_badge.png 2015-02-28 14:28:23 +0000 differ
=== added file 'custom_mate-old_badge.png'
6Binary files custom_mate-old_badge.png 1970-01-01 00:00:00 +0000 and custom_mate-old_badge.png 2015-02-28 14:28:23 +0000 differ6Binary files custom_mate-old_badge.png 1970-01-01 00:00:00 +0000 and custom_mate-old_badge.png 2015-02-28 14:28:23 +0000 differ
=== modified file 'custom_mate_badge.png'
7Binary files custom_mate_badge.png 2014-11-27 01:01:37 +0000 and custom_mate_badge.png 2015-02-28 14:28:23 +0000 differ7Binary files custom_mate_badge.png 2014-11-27 01:01:37 +0000 and custom_mate_badge.png 2015-02-28 14:28:23 +0000 differ
=== added symlink 'custom_sugar-session-0.96_badge.png'
=== target is u'custom_usr_badge.png'
=== added symlink 'custom_sugar-session-0.98_badge.png'
=== target is u'custom_usr_badge.png'
=== modified file 'debian/changelog'
--- debian/changelog 2015-01-18 12:53:25 +0000
+++ debian/changelog 2015-02-28 14:28:23 +0000
@@ -1,3 +1,20 @@
1unity-greeter-badges (0.4-0ubuntu1) vivid; urgency=medium
2
3 * New upstream release.
4 * debian/install
5 - Simplify file to use wildcard. We will handle the special cases
6 in debian/rules.
7 - Remove executable bit; not needed since we no longer use dh-exec.
8 * debian/control
9 - Remove dh-exec from Build-Depends; no longer needed.
10 * debian/rules
11 - Add override_dh_install target to remove badges found in other packages
12 and fix resulting broken symlinks. This function was previously
13 performed by dh-exec using debian/install, but this was harder to
14 maintain.
15
16 -- Doug Torrance <dtorrance@monmouthcollege.edu> Sat, 28 Feb 2015 07:30:52 -0600
17
1unity-greeter-badges (0.3-0ubuntu1) vivid; urgency=medium18unity-greeter-badges (0.3-0ubuntu1) vivid; urgency=medium
219
3 * New upstream release.20 * New upstream release.
421
=== modified file 'debian/control'
--- debian/control 2015-01-18 12:53:25 +0000
+++ debian/control 2015-02-28 14:28:23 +0000
@@ -3,7 +3,7 @@
3Priority: optional3Priority: optional
4Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>4Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
5XSBC-Original-Maintainer: Doug Torrance <dtorrance@monmouthcollege.edu>5XSBC-Original-Maintainer: Doug Torrance <dtorrance@monmouthcollege.edu>
6Build-Depends: debhelper (>= 9), dh-exec6Build-Depends: debhelper (>= 9)
7Standards-Version: 3.9.67Standards-Version: 3.9.6
8Homepage: http://gnome-look.org/content/show.php/?content=1587648Homepage: http://gnome-look.org/content/show.php/?content=158764
9Vcs-Git: https://github.com/d-torrance/unity-greeter-badges.git9Vcs-Git: https://github.com/d-torrance/unity-greeter-badges.git
1010
=== modified file 'debian/install' (properties changed: +x to -x)
--- debian/install 2015-01-18 12:53:25 +0000
+++ debian/install 2015-02-28 14:28:23 +0000
@@ -1,61 +1,2 @@
1#!/usr/bin/dh-exec1custom_*_badge.png usr/share/unity-greeter
2# Some badges are already provided by packages in Ubuntu -- these are not2debian/custom_*_badge.png usr/share/unity-greeter
3# installed. There are a few badges not provided in other packages which
4# link to them. We rename them instead.
5custom_afterstep_badge.png usr/share/unity-greeter
6custom_amiwm_badge.png usr/share/unity-greeter
7custom_awesome_badge.png usr/share/unity-greeter
8custom_blackbox_badge.png usr/share/unity-greeter
9# custom_cairo-dock_badge.png provided by cairo-dock-data
10custom_cairo-dock_badge.png => usr/share/unity-greeter/custom_cairo-dock-fallback_badge.png
11custom_cairo-dock_badge.png => usr/share/unity-greeter/custom_cairo-dock-unity_badge.png
12custom_chromium_badge.png usr/share/unity-greeter
13custom_cinnamon_badge.png usr/share/unity-greeter
14custom_cinnamon2d_badge.png usr/share/unity-greeter
15custom_dwm_badge.png usr/share/unity-greeter
16custom_enlightenment_badge.png usr/share/unity-greeter
17custom_etoile_badge.png usr/share/unity-greeter
18custom_evilwm_badge.png usr/share/unity-greeter
19custom_fluxbox_badge.png usr/share/unity-greeter
20custom_fvwm1_badge.png usr/share/unity-greeter
21custom_fvwm_badge.png usr/share/unity-greeter
22custom_fvwm-crystal_badge.png usr/share/unity-greeter
23custom_gnome-xmonad_badge.png usr/share/unity-greeter
24custom_gnustep_badge.png usr/share/unity-greeter
25custom_herbstluftwm_badge.png usr/share/unity-greeter
26custom_i3_badge.png usr/share/unity-greeter
27custom_IceWM_badge.png usr/share/unity-greeter
28custom_IceWM-Experimental_badge.png usr/share/unity-greeter
29custom_IceWM-Lite_badge.png usr/share/unity-greeter
30custom_icewm-session_badge.png usr/share/unity-greeter
31custom_larswm_badge.png usr/share/unity-greeter
32# custom_Lubuntu_badge.png and custom_LXDE_badge.png provided by lubuntu-artwork
33custom_LXDE_badge.png => usr/share/unity-greeter/custom_Lubuntu-Netbook_badge
34custom_mate_badge.png usr/share/unity-greeter
35custom_mythbuntu_badge.png usr/share/unity-greeter
36custom_openbox_badge.png usr/share/unity-greeter
37custom_openbox-gnome_badge.png usr/share/unity-greeter
38custom_openbox-kde_badge.png usr/share/unity-greeter
39custom_openbsd-cwm_badge.png usr/share/unity-greeter
40custom_pantheon_badge.png usr/share/unity-greeter
41custom_pekwm_badge.png usr/share/unity-greeter
42custom_ratpoison_badge.png usr/share/unity-greeter
43custom_razor_badge.png usr/share/unity-greeter
44custom_sawfish_badge.png usr/share/unity-greeter
45custom_stumpwm_badge.png usr/share/unity-greeter
46custom_subtle_badge.png usr/share/unity-greeter
47custom_sugar-session-0.84_badge.png usr/share/unity-greeter
48custom_sugar-session-0.86_badge.png usr/share/unity-greeter
49custom_sugar-session-0.88_badge.png usr/share/unity-greeter
50custom_sugar-session-0.90_badge.png usr/share/unity-greeter
51custom_trinity_badge.png usr/share/unity-greeter
52custom_twm_badge.png usr/share/unity-greeter
53custom_ubuntustudio_badge.png usr/share/unity-greeter
54custom_usr_badge.png usr/share/unity-greeter
55# custom_wmaker-common_badge.png provided by wmaker-common
56custom_wmii_badge.png usr/share/unity-greeter
57custom_XBMC_badge.png usr/share/unity-greeter
58custom_xmonad_badge.png usr/share/unity-greeter
59# custom_xubuntu_badge.png provided by xubuntu-artwork
60custom_xubuntu_badge.png => /usr/share/unity-greeter/custom_xfce_badge.png
61debian/custom_mwm_badge.png usr/share/unity-greeter
623
=== modified file 'debian/rules'
--- debian/rules 2015-01-18 12:53:25 +0000
+++ debian/rules 2015-02-28 14:28:23 +0000
@@ -1,7 +1,34 @@
1#!/usr/bin/make -f1#!/usr/bin/make -f
22
3DATADIR=$(CURDIR)/debian/unity-greeter-badges/usr/share/unity-greeter
4
5# Badges found in other packages
6BADGESTOREMOVE = cairo-dock #cairo-dock-data
7BADGESTOREMOVE += LXDE Lubuntu #lubuntu-artwork
8BADGESTOREMOVE += wmaker-common #wmaker-common
9BADGESTOREMOVE += xubuntu #xubuntu-artwork
10
11# But if we remove these, we break some symbolic links
12BROKENLINKS = cairo-dock-fallback cairo-dock-unity #cairo-dock
13BROKENLINKS += Lubuntu-Netbook lubuntu-nexus7 lxgames QLubuntu #LXDE
14BROKENLINKS += xfce #xubuntu
15
3%:16%:
4 dh $@17 dh $@
518
19override_dh_install:
20 dh_install
21
22# Remove badges provided in other packages
23 for BADGE in $(BADGESTOREMOVE); do \
24 rm $(DATADIR)/custom_$$BADGE\_badge.png; \
25 done
26
27# Fix broken symlinks
28 for BADGE in $(BROKENLINKS); do \
29 rm $(DATADIR)/custom_$$BADGE\_badge.png; \
30 cp -L $(CURDIR)/custom_$$BADGE\_badge.png $(DATADIR); \
31 done
32
6get-orig-source:33get-orig-source:
7 uscan --verbose --force-download --rename34 uscan --verbose --force-download --rename

Subscribers

People subscribed via source and target branches

to all changes: