Merge lp:~primes2h/ubuntu-qa-website/bug_731999 into lp:~ubuntu-qa-website-devel/ubuntu-qa-website/trunk

Proposed by Sergio Zanchetta on 2011-03-09
Status: Merged
Merged at revision: 154
Proposed branch: lp:~primes2h/ubuntu-qa-website/bug_731999
Merge into: lp:~ubuntu-qa-website-devel/ubuntu-qa-website/trunk
Diff against target: 12 lines (+1/-1)
1 file modified
code/modules/qatracker/qatracker.display.php (+1/-1)
To merge this branch: bzr merge lp:~primes2h/ubuntu-qa-website/bug_731999
Reviewer Review Type Date Requested Status
Jean-Baptiste Lallement 2011-03-09 Approve on 2011-03-10
Review via email: mp+52692@code.launchpad.net

Description of the change

This is a fix for the LP bug #731999. Tested products in the laptop summary are now filtered by site.

To post a comment you must log in.
Jean-Baptiste Lallement (jibel) wrote :

approved. Thanks.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'code/modules/qatracker/qatracker.display.php'
2--- code/modules/qatracker/qatracker.display.php 2011-02-17 16:09:49 +0000
3+++ code/modules/qatracker/qatracker.display.php 2011-03-09 14:41:57 +0000
4@@ -1074,7 +1074,7 @@
5 LEFT JOIN qatracker_milestone ON qatracker_milestone.id=qatracker_build.milestoneid
6 LEFT JOIN qatracker_product ON qatracker_product.id=qatracker_build.productid
7 LEFT JOIN users ON qatracker_result.reporterid=users.uid
8- WHERE users.name='".$reporter."' AND qatracker_milestone.title like '".$name."%' GROUP BY product");
9+ WHERE users.name='".$reporter."' AND qatracker_milestone.title like '".$name."%' AND qatracker_product.siteid='".$site->id."' GROUP BY product");
10 $first=True;
11 while($item = db_fetch_object($query)) {
12 if ($first)

Subscribers

People subscribed via source and target branches

to status/vote changes: