Code review comment for lp:~prafulla-t/drizzle/drz-fast-timer-and-time-profile-refactoring
Revision history for this message
| Brian Aker (brianaker) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
Hi!
A couple of things:
1) We want to avoid using pthread_key_t because it ties sessions to threads, and we want sessions to float between threads.
2) At the beginning of each query we call gettimeofday() in Session. You can base any calls you need off of that initially.
3) The style in the code is off from our coding style.
How can we provide this data to a user? Have you thought about providing a table function to display it for the last query?
Cheers,
-Brian
(BTW I will be offline for an extended period of time starting this weekend, so I will be slow to respond for the next two weeks).