Merge lp:~powersj/vmbuilder/jenkins_kvm into lp:~ubuntu-on-ec2/vmbuilder/jenkins_kvm

Proposed by Joshua Powers
Status: Merged
Merged at revision: 835
Proposed branch: lp:~powersj/vmbuilder/jenkins_kvm
Merge into: lp:~ubuntu-on-ec2/vmbuilder/jenkins_kvm
Diff against target: 62 lines (+33/-19)
1 file modified
jenkins/CloudImages_Base_Release_Delta.sh (+33/-19)
To merge this branch: bzr merge lp:~powersj/vmbuilder/jenkins_kvm
Reviewer Review Type Date Requested Status
Robert C Jennings (community) Approve
David Krauser (community) Approve
Review via email: mp+385215@code.launchpad.net

Commit message

Fix the release, codename, and suite mappings.

The mappings are completely out of date and not correct at all for the last couple LTS. Furthermore, then script used to translate a suite (e.g. focal) to version is not working and even states that it would not work after the Z release.

To post a comment you must log in.
Revision history for this message
Steve Langasek (vorlon) wrote :

Would it be better to use distro-info for this rather than hard coding a mapping that will be perpetually out of date?

Revision history for this message
Joshua Powers (powersj) wrote :

Looks like distro-info's "--fullname" gets us what we eventually use:

$ distro-info --series=bionic --fullname
Ubuntu 18.04 LTS "Bionic Beaver"

Except this runs on Jerff with version 0.8 and I do not see the --series flag till version 0.13.

Revision history for this message
David Krauser (davidkrauser) wrote :

Seems like a reasonable change, but are we still using this? What do we use it for?

Revision history for this message
Joshua Powers (powersj) wrote :
Revision history for this message
David Krauser (davidkrauser) :
review: Approve
Revision history for this message
Robert C Jennings (rcj) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'jenkins/CloudImages_Base_Release_Delta.sh'
2--- jenkins/CloudImages_Base_Release_Delta.sh 2015-12-03 16:42:51 +0000
3+++ jenkins/CloudImages_Base_Release_Delta.sh 2020-06-05 17:43:29 +0000
4@@ -190,25 +190,39 @@
5 sed -e 's,====,,g' -e 's,^, *,g' | sort -k2)
6
7 # Generate the email template
8-VER=$(${kvm}/ubuntu-adj2version ${SUITE})
9-
10-case ${VER} in
11- *8.04*) VER="${VER} LTS";
12- CODENAME="Hardy Heron";;
13- *10.04*) VER="${VER} LTS";
14- CODENAME="Lucid Lynx";;
15- *11.04*) CODENAME="Natty Narwhal";;
16- *11.10*) CODENAME="Oneiric Ocelot";;
17- *12.04*) VER="${VER} LTS";
18- CODENAME="Precise Pangolin";;
19- *12.10*) CODENAME="Quantal Queztal";;
20- *13.04*) CODENAME="Raring Ringtail";;
21- *13.10*) CODENAME="Saucy Salamander";;
22- *14.04*) VER="${VER} LTS";
23- CODENAME="Trusty Tahr";;
24- *14.10*) CODENAME="Utopic Unicorn";;
25- *15.04*) CODENAME="Vivid Vervet";;
26- *15.10*) CODENAME="Wily Werewolf";;
27+case ${SUITE} in
28+ precise)
29+ VER='12.04 LTS'
30+ CODENAME='Precise Pangolin'
31+ ;;
32+ trusty)
33+ VER='14.04 LTS'
34+ CODENAME='Trusty Tahr'
35+ ;;
36+ xenial)
37+ VER='16.04 LTS'
38+ CODENAME='Xenial Xerus'
39+ ;;
40+ bionic)
41+ VER='18.04 LTS'
42+ CODENAME='Bionic Beaver'
43+ ;;
44+ eoan)
45+ VER='19.10'
46+ CODENAME='Eoan Ermine'
47+ ;;
48+ focal)
49+ VER='20.04 LTS'
50+ CODENAME='Focal Fossa'
51+ ;;
52+ groovy)
53+ VER='20.10'
54+ CODENAME='Groovy Gorilla'
55+ ;;
56+ *)
57+ echo "Unknown suite: '${SUITE}'" >&2
58+ exit 1
59+ ;;
60 esac
61
62 email_name="${WORKSPACE}/${SUITE}-release_announcement.email"

Subscribers

People subscribed via source and target branches