Code review comment for lp:~posulliv/drizzle/simple-tc-engine

Revision history for this message
Stewart Smith (stewart) wrote :

the delete table paths seem to be a bit strange. it looks like you're deleting it on the close of the last tableshare, although the proper way would be to do it when explicitly called to remove the table (and check exists/not exists).

If you wanted to be fancy and demo the data dictionary APIs, you could have a (on disk) tc db of table names with the data being the table proto.

review: Needs Information

« Back to merge proposal