Code review comment for lp:~posulliv/drizzle/dtrace-probes

Revision history for this message
Padraig O'Sullivan (posulliv) wrote :

This branch contains a port of the latest dtrace probes from mysql 6.0. I updated the pandora build 64-bit file also to ensure that these probes are actually enabled (before dtrace support did not work correctly in drizzle on 64-bit platforms).

I added some calls in various places to these dtrace probes. I'll continue to work on identifying areas where probes can be inserted and also think about new probes that we could come up with that would be useful.

In the future, I'd also like to be able to let plugins provide their own dtrace probes if they so wish but I think we are a bit away from that for the moment.

I've tested that these probes work on solaris but not on OSX yet. I'll write up an article with some examples of using these probes this week.

-Padraig

« Back to merge proposal