Code review comment for lp:~posulliv/drizzle/bug337038-dec-trunc-should-error

Hi Padraig! Sorry to disapprove again, but this worries me:

110 -10.56
111 +10.55
112 NULL
113 -10.55
114 --10.56
115 -11.00
116 -10.00
117 -10.55
118 -10.56
119 --10.55
120 --10.56
121 -11.00
122 -10.00
123 -2.00
124 +-10.55
125 +11.00
126 +10.00
127 +10.55
128 +10.55
129 +-10.55
130 +-10.55
131 +11.00
132 +10.00
133 +99.99

When I see test case results go from one value to another, I check very carefully to ensure that the patch didn't break something accidentally. In this case, I see that one row (line 123 in the diff output) went from 2.00 to 99.99 (line 133). Is this correct? Or is there a fault in either our test case or the original one?

Cheers!

jay

p.s. Yeah, I know this is annoying work...sorry!