Code review comment for lp:~posulliv/drizzle/bug337038-dec-trunc-should-error
Revision history for this message
| Padraig O'Sullivan (posulliv) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
1b1ed1a
(Get the code!)
Thanks for the comments Jay. I just pushed my changes to the branch where I took your comments into consideration. I separated multi-value INSERT statements into single INSERT statements and tried to add comments where I could. All of the numbers were already present in the test case before I started on this bug fix so I tried to add appropriate comments where possible. Let me know if you think I should add more comments or anything else.
-Padraig