Merge lp:~popey/ubuntu-rssreader-app/fix-1343505 into lp:~ubuntu-shorts-dev/ubuntu-rssreader-app/trunk

Status: Merged
Approved by: Roman Shchekin
Approved revision: 260
Merged at revision: 260
Proposed branch: lp:~popey/ubuntu-rssreader-app/fix-1343505
Merge into: lp:~ubuntu-shorts-dev/ubuntu-rssreader-app/trunk
Diff against target: 52 lines (+1/-7)
2 files modified
CMakeLists.txt (+0/-5)
click/manifest.json.in (+1/-2)
To merge this branch: bzr merge lp:~popey/ubuntu-rssreader-app/fix-1343505
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Ubuntu Shorts Developers Pending
Review via email: mp+227247@code.launchpad.net

Commit message

fix 1343505 to remove urls

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'CMakeLists.txt'
--- CMakeLists.txt 2014-04-02 05:10:33 +0000
+++ CMakeLists.txt 2014-07-17 19:17:42 +0000
@@ -9,7 +9,6 @@
99
10set(APP_NAME shorts)10set(APP_NAME shorts)
11set(DESKTOP_FILE "${PROJECT_NAME}_${APP_NAME}.desktop")11set(DESKTOP_FILE "${PROJECT_NAME}_${APP_NAME}.desktop")
12set(URLS_FILE "${PROJECT_NAME}_${APP_NAME}.url-dispatcher")
13set(APP_HARDCODE shorts-app)12set(APP_HARDCODE shorts-app)
14set(MAIN_QML shorts-app.qml)13set(MAIN_QML shorts-app.qml)
15set(ICON_FILE rssreader-app@30.png)14set(ICON_FILE rssreader-app@30.png)
@@ -26,7 +25,6 @@
26 set(ICON ${ICON_FILE})25 set(ICON ${ICON_FILE})
27 set(EXEC "qmlscene ${MAIN_QML}")26 set(EXEC "qmlscene ${MAIN_QML}")
28 set(DESKTOP_DIR ${DATA_DIR})27 set(DESKTOP_DIR ${DATA_DIR})
29 set(URLS_DIR ${DATA_DIR})
30else(CLICK_MODE)28else(CLICK_MODE)
31 set(DATA_DIR ${CMAKE_INSTALL_DATADIR}/${APP_HARDCODE})29 set(DATA_DIR ${CMAKE_INSTALL_DATADIR}/${APP_HARDCODE})
32 set(EXEC ${APP_HARDCODE})30 set(EXEC ${APP_HARDCODE})
@@ -36,7 +34,6 @@
36 install(PROGRAMS ${CMAKE_CURRENT_BINARY_DIR}/${APP_HARDCODE}34 install(PROGRAMS ${CMAKE_CURRENT_BINARY_DIR}/${APP_HARDCODE}
37 DESTINATION ${CMAKE_INSTALL_BINDIR})35 DESTINATION ${CMAKE_INSTALL_BINDIR})
38 set(DESKTOP_DIR ${CMAKE_INSTALL_DATADIR}/applications)36 set(DESKTOP_DIR ${CMAKE_INSTALL_DATADIR}/applications)
39 set(URLS_DIR ${CMAKE_INSTALL_DATADIR}/url-dispatcher/urls)
40endif(CLICK_MODE)37endif(CLICK_MODE)
4138
42file(GLOB_RECURSE I18N_SRC_FILES39file(GLOB_RECURSE I18N_SRC_FILES
@@ -61,8 +58,6 @@
61install(FILES ${CMAKE_CURRENT_BINARY_DIR}/${DESKTOP_FILE}58install(FILES ${CMAKE_CURRENT_BINARY_DIR}/${DESKTOP_FILE}
62 DESTINATION ${DESKTOP_DIR})59 DESTINATION ${DESKTOP_DIR})
6360
64install(FILES ${URLS_FILE} DESTINATION ${URLS_DIR})
65
66# Tests61# Tests
67enable_testing()62enable_testing()
6863
6964
=== modified file 'click/manifest.json.in'
--- click/manifest.json.in 2014-07-04 08:41:07 +0000
+++ click/manifest.json.in 2014-07-17 19:17:42 +0000
@@ -4,8 +4,7 @@
4 "hooks": {4 "hooks": {
5 "@APP_NAME@": {5 "@APP_NAME@": {
6 "apparmor": "apparmor.json",6 "apparmor": "apparmor.json",
7 "desktop": "@DESKTOP_FILE@",7 "desktop": "@DESKTOP_FILE@"
8 "urls": "@URLS_FILE@"
9 }8 }
10 },9 },
11 "icon": "@ICON@",10 "icon": "@ICON@",
1211
=== removed file 'com.ubuntu.shorts_shorts.url-dispatcher'

Subscribers

People subscribed via source and target branches