Code review comment for lp:~pkunal-parmar/ubuntu-calendar-app/new_month_yearview

Revision history for this message
Kunal Parmar (pkunal-parmar) wrote :

> Another not so minor issue: in the month view, days are shifted by one, i.e.
> with my current locale settings (fr_FR) the month view displays the first of
> September as a Monday, whereas it was a Sunday. This is a regression compared
> to the current implementation, which correctly displays the first of September
> as a Sunday.
>
> The year view is also affected, so this is a bug, but not a regression as the
> bug was already present in the year view in the current implementation.

Tried to fix, it looks fine to me, Can you confirm ?

« Back to merge proposal