Code review comment for lp:~pkunal-parmar/ubuntu-calendar-app/new_month_yearview

Revision history for this message
Kunal Parmar (pkunal-parmar) wrote :

> Thanks for your time and the big patch Kunal!
>
> Looking to the design guideline I have noticed some things:
> - Page 4 of UDS presentation: In the year view also the name of the month is
> in the rounded box
> - Page 4 of UDS presentation: In the year view there is a label, on right of
> the name of the month, with the year
> - There is no animation when you click on a month
> - Page 5 of UDS presentation: In the month view also the name of the month is
> in the rounded box
> - Page 5 of UDS presentation: In the year view there is a label, on right of
> the name of the month, with the year
> - Page 5 of UDS presentation: There is no current date in design guideline, in
> month view
>
> Also, when you switch tab from month to year, start month is Jan, I think that
> the start month has to be the current one.
>
> However, they are details, great job Kunal!

Hi, I addressed your comments except scrolling one and animation. I will create another merge request for scrolling to current month. I need some time for that. and animation we are not focusing right now.

« Back to merge proposal