Merge lp:~pkunal-parmar/ubuntu-calendar-app/YearViewDayLabel into lp:ubuntu-calendar-app

Proposed by Kunal Parmar
Status: Merged
Approved by: Mihir Soni
Approved revision: 479
Merged at revision: 479
Proposed branch: lp:~pkunal-parmar/ubuntu-calendar-app/YearViewDayLabel
Merge into: lp:ubuntu-calendar-app
Diff against target: 12 lines (+1/-1)
1 file modified
MonthComponent.qml (+1/-1)
To merge this branch: bzr merge lp:~pkunal-parmar/ubuntu-calendar-app/YearViewDayLabel
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Mihir Soni Approve
Review via email: mp+236251@code.launchpad.net

Commit message

Resolves Bug #1357255

Description of the change

Resolves Bug #1357255

Year view has day names too condensed

To post a comment you must log in.
Revision history for this message
Kunal Parmar (pkunal-parmar) wrote :

"It's certainly common in the UK to use S M T W T F S, if that's common in other regions then yes, I'd say using single letters is appropriate and desirable."

As pope commented on Bug report, I am too unsure if this is appropriate for other language or not.
But proposing change anyway so we can debate and come to some solution.

As of now just using first letter of Day in YearView.

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Mihir Soni (mihirsoni) wrote :

Looks good to me!!
Thanks kunal for MR.

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'MonthComponent.qml'
2--- MonthComponent.qml 2014-09-20 10:45:35 +0000
3+++ MonthComponent.qml 2014-09-28 12:13:31 +0000
4@@ -274,7 +274,7 @@
5 id: weekDay
6 width: parent.width / 7
7 property var day :Qt.locale().standaloneDayName(( Qt.locale().firstDayOfWeek + index), Locale.ShortFormat)
8- text: day;
9+ text: isYearView ? day.charAt(0) : day;
10 horizontalAlignment: Text.AlignHCenter
11 fontSize: root.dayLabelFontSize
12 color: "white"

Subscribers

People subscribed via source and target branches

to status/vote changes: