Merge lp:~pkunal-parmar/ubuntu-calendar-app/TimePickerHeight into lp:ubuntu-calendar-app

[Kunal Parmar]

Resolving Bug #1419671 ,

Increasing height of Time and Date picker's height

Resolving Bug #1419671 ,

Increasing height of Time and Date picker's height

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:580
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1073/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-vivid/1088
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/1088/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-vivid-amd64-ci/70

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1073/rebuild

review: Needs Fixing (continuous-integration)

[lp:~pkunal-parmar/ubuntu-calendar-app/TimePickerHeight]

581. By Kunal Parmar on 2015-02-17

dummy

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:581
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1075/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-vivid/1101
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/1101/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-vivid-amd64-ci/72

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1075/rebuild

review: Needs Fixing (continuous-integration)

[Kunal Parmar (pkunal-parmar)]

> FAILED: Continuous integration, rev:581
> http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1075/
> Executed test runs:
> UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-vivid/1101
> deb: http://91.189.93.70:8080/job/generic-mediumtests-
> vivid/1101/artifact/work/output/*zip*/output.zip
> SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-vivid-
> amd64-ci/72
>
> Click here to trigger a rebuild:
> http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1075/rebuild

Apparently, its failing because after increasing the height of TimePicker field, Autopilot is not able to click on Add cotact button. We need to modify the AP to fix this.

[lp:~pkunal-parmar/ubuntu-calendar-app/TimePickerHeight]

582. By Kunal Parmar on 2015-02-18

AP fix

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:582
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1081/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-vivid/1117
        deb: http://91.189.93.70:8080/job/generic-mediumtests-vivid/1117/artifact/work/output/*zip*/output.zip
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-vivid-amd64-ci/78

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/1081/rebuild

review: Approve (continuous-integration)

[Alan Pope 🍺🐧🐱 🦄 (popey)]

Looks good to me!

review: Approve

=== modified file 'NewEventEntryField.qml'
--- NewEventEntryField.qml	2014-09-15 16:07:15 +0000
+++ NewEventEntryField.qml	2015-02-19 13:24:49 +0000
@@ -24,7 +24,7 @@
 
     property bool highlighted: false
 
-    height: units.gu(3)
+    height: units.gu(6)
 
     verticalAlignment: Text.AlignVCenter
     color: highlighted ? "#2C001E" : Theme.palette.normal.baseText
 
=== modified file 'tests/autopilot/calendar_app/__init__.py'
--- tests/autopilot/calendar_app/__init__.py	2015-02-17 05:41:46 +0000
+++ tests/autopilot/calendar_app/__init__.py	2015-02-19 13:24:49 +0000
@@ -232,6 +232,23 @@
 
         self.pointing_device.drag(x_start, y_line, x_stop, y_line)
 
+    def swipe_view_vertical(self, direction, view, y_pad=0.08):
+        """Swipe the given view to up or down.
+
+        Args:
+            direction:
+        """
+
+        start = (-direction * y_pad) % 1
+        stop = (direction * y_pad) % 1
+
+        x_line = view.globalRect[0] + view.globalRect[2] / 2
+        y_start = view.globalRect[1] + view.globalRect[3] * start
+        y_stop = view.globalRect[1] + view.globalRect[3] * stop
+
+        self.pointing_device.drag(x_line, y_start, x_line, y_stop)
+        sleep(1)
+
     def to_local_date(self, date):
         utc = date.replace(tzinfo=tz.tzutc())
         local = utc.astimezone(tz.tzlocal())
@@ -616,6 +633,7 @@
     def _fill_guests(self, guests):
         guests_btn = self.select_single('Button', objectName='addGuestButton')
         main_view = self.get_root_instance().select_single(MainView)
+        main_view.swipe_view_vertical(1, self)
 
         for guest in guests:
             self.pointing_device.click_object(guests_btn)