Code review comment for lp:~pkunal-parmar/ubuntu-calendar-app/TimeLineView

Revision history for this message
Kunal Parmar (pkunal-parmar) wrote :

> Looks good. Two last details:
>
> - You haven’t addressed my comment about setting the background color to
> "white" explicitly.
>
> - Since there are new strings, you need to regenerate the translation
> template. To do that, just invoke the following command in your branch, and
> commit the modified .pot file:
>
> xgettext --from-code=UTF-8 -o po/ubuntu-calendar-app.pot -D . --c++ --qt
> --add-comments=TRANSLATORS --keyword=tr --package-name=ubuntu-calendar-app -s
> *.qml

ahh, I thought I made changes to set background, but then forgotten about it. Did it now. and also updated the pot file.

« Back to merge proposal