Code review comment for lp:~pkunal-parmar/ubuntu-calendar-app/TimeLineView

Revision history for this message
Olivier Tilloy (osomon) wrote :

75 + onDayStartChanged: {
76 + if (status == Loader.Ready) {
77 + item.dayStart = dayStart;
78 + }
79 + }

To make this more declarative, you can replace the above block (and remove the assignment of item.dayStart in onStatusChanged) by:

    Binding {
        target: item
        property: "dayStart"
        value: eventViewDelegate.dayStart
    }

(no need to check the status, as item will be null if the status is ≠ Loader.Ready).

review: Needs Fixing

« Back to merge proposal