Code review comment for lp:~pkunal-parmar/ubuntu-calendar-app/TimeLineView

Revision history for this message
Kunal Parmar (pkunal-parmar) wrote :

> If I read correctly the code of the eventLineColumn, there can be only one
> event per hour. And even if there’s only one (or no) event, there are 24
> invisible delegates sitting there, eating up memory. Or am I misunderstanding
> the code?
>
> I think this is typically a case where we want dynamic object creation and
> deletion, not a repeater inside a column. This will give us more flexibility,
> allowing to have as many (or as few) events as needed, positioned exactly
> where they need to be.

I addressed almost all your concern except following one.

"The TimeLineView component has a number of properties and signals in common with the DiaryView component: they should inherit from a common base component."

This I will address in another review request.

« Back to merge proposal