Merge lp:~pkunal-parmar/ubuntu-calendar-app/RemoveUbuntuShape into lp:ubuntu-calendar-app

Proposed by Kunal Parmar
Status: Merged
Approved by: Mihir Soni
Approved revision: 291
Merged at revision: 292
Proposed branch: lp:~pkunal-parmar/ubuntu-calendar-app/RemoveUbuntuShape
Merge into: lp:ubuntu-calendar-app
Diff against target: 52 lines (+17/-24)
1 file modified
NewEvent.qml (+17/-24)
To merge this branch: bzr merge lp:~pkunal-parmar/ubuntu-calendar-app/RemoveUbuntuShape
Reviewer Review Type Date Requested Status
Mihir Soni Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+221069@code.launchpad.net

Commit message

Removing ubuntu shape from Description field, as per design team's suggestion

Description of the change

Removing ubuntu shape from Description field, as per design team's suggestion

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Mihir Soni (mihirsoni) wrote :

Looks good to me.
Thanks Kunal

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'NewEvent.qml'
--- NewEvent.qml 2014-05-23 07:21:51 +0000
+++ NewEvent.qml 2014-05-27 11:43:26 +0000
@@ -394,31 +394,24 @@
394 objectName: "newEventName"394 objectName: "newEventName"
395 }395 }
396396
397 UbuntuShape{397 Column{
398 width:parent.width398 id: descriptionColumn
399 height: descriptionColumn.height399 width: parent.width
400400 spacing: units.gu(1)
401 Column{401
402 id: descriptionColumn402 Label {
403 text: i18n.tr("Description")
404 anchors.margins: units.gu(0.5)
405 anchors.left: parent.left
406 }
407
408 TextArea{
409 id: messageEdit
403 width: parent.width410 width: parent.width
404 anchors.top: parent.top411 color: focus ? "#2C001E" : "#5D5D5D"
405 anchors.topMargin: units.gu(0.5)412 // default style
406 spacing: units.gu(1)413 font {
407414 pixelSize: focus ? FontUtils.sizeToPixels("large") : FontUtils.sizeToPixels("medium")
408 Label {
409 text: i18n.tr("Description")
410 anchors.margins: units.gu(0.5)
411 anchors.left: parent.left
412 }
413
414 TextArea{
415 id: messageEdit
416 width: parent.width
417 color: focus ? "#2C001E" : "#5D5D5D"
418 // default style
419 font {
420 pixelSize: focus ? FontUtils.sizeToPixels("large") : FontUtils.sizeToPixels("medium")
421 }
422 }415 }
423 }416 }
424 }417 }

Subscribers

People subscribed via source and target branches

to status/vote changes: