Code review comment for lp:~pkunal-parmar/ubuntu-calendar-app/Refactoring

Revision history for this message
Olivier Tilloy (osomon) wrote :

807 + onStateChanged: {
808 + monthView.compressed = (eventView.state == "EXPANDED");
809 }

As I was suggesting in a previous comment, this should be removed, and *inside* the MonthView instance, set the value of 'compressed':

    MonthView {
        […]
        compressed: eventView.state == "EXPANDED"
        […]
    }

review: Needs Fixing

« Back to merge proposal