Code review comment for lp:~pkunal-parmar/ubuntu-calendar-app/Refactoring

Revision history for this message
Kunal Parmar (pkunal-parmar) wrote :

> > 192 + property string previousItemState: "COMPRESSED";
> >
> > I’m not sure I understand what this property is for? If the goal is to
> ensure
> > that all the delegates get the same state, then it’s not working. In that
> > case, you’d need to define a 'delegateState' property on eventView, so that
> > all delegates’ states are bound to it.
>
> previousItemState property's intention was to preserve state, when going from
> DiaryView to TimeLineView.
> But you are right, we also need to preserve state when we change day by
> scrolling, this I overlooked.

This approach was not working, To resolve I put a reverse binding from EventView to Delegate so all delegate share the same state,
It also works when you change from DiaryView to TimeLineView.

        //share state from eventview to delegate, so that all delegate share the same state
        Binding{
            target: eventViewDelegate.item
            property: "state"
            value: eventView.state
        }

« Back to merge proposal