Code review comment for lp:~pkunal-parmar/ubuntu-calendar-app/Refactoring

Revision history for this message
Kunal Parmar (pkunal-parmar) wrote :

> To make the code more readable, instead of explicitly triggering state changes
> upon contentYChanged or draggingChanged, use the 'when' property of the states
> (http://qt-project.org/doc/qt-5.0/qtquick/qml-qtquick2-state.html#when-prop).

I tried to use this, but failed, mostly I got "Binding loop detected for property "when"" error.
I am not sure how this "when" works, but we want expand() and compress() to be called on the first time when Dragging and ContentY changes. Not sure how that can be captured with "when".

« Back to merge proposal