Merge lp:~pkunal-parmar/ubuntu-calendar-app/NoDefaultSelection_Week into lp:ubuntu-calendar-app

Proposed by Kunal Parmar
Status: Merged
Approved by: Mihir Soni
Approved revision: 699
Merged at revision: 702
Proposed branch: lp:~pkunal-parmar/ubuntu-calendar-app/NoDefaultSelection_Week
Merge into: lp:ubuntu-calendar-app
Diff against target: 71 lines (+5/-5)
4 files modified
EventListModel.qml (+0/-1)
TimeLineBaseComponent.qml (+1/-2)
TimeLineHeader.qml (+2/-0)
TimeLineHeaderComponent.qml (+2/-2)
To merge this branch: bzr merge lp:~pkunal-parmar/ubuntu-calendar-app/NoDefaultSelection_Week
Reviewer Review Type Date Requested Status
Mihir Soni Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+265889@code.launchpad.net

Commit message

By default no selection in weekview, this is current implementation in MonthView as well

Description of the change

By default no selection in weekview, this is current implementation in MonthView as well

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Mihir Soni (mihirsoni) wrote :

Looks good to me !!

Thanks Kunal

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'EventListModel.qml'
--- EventListModel.qml 2015-05-14 13:03:02 +0000
+++ EventListModel.qml 2015-07-25 05:21:13 +0000
@@ -69,7 +69,6 @@
69 var collections = eventModel.collections;69 var collections = eventModel.collections;
70 for(var i = 0 ; i < collections.length ; ++i) {70 for(var i = 0 ; i < collections.length ; ++i) {
71 var cal = collections[i];71 var cal = collections[i];
72 //print(cal.name + " ---- " + cal.extendedMetaData("collection-readonly"));
73 if( cal.extendedMetaData("collection-type") === "Calendar" ) {72 if( cal.extendedMetaData("collection-type") === "Calendar" ) {
74 cals.push(cal);73 cals.push(cal);
75 }74 }
7675
=== modified file 'TimeLineBaseComponent.qml'
--- TimeLineBaseComponent.qml 2015-06-04 14:13:32 +0000
+++ TimeLineBaseComponent.qml 2015-07-25 05:21:13 +0000
@@ -66,12 +66,10 @@
66 var diff = weekDay - Qt.locale().firstDayOfWeek66 var diff = weekDay - Qt.locale().firstDayOfWeek
67 diff = diff < 0 ? 6 : diff67 diff = diff < 0 ? 6 : diff
6868
69 print(diff + ", " + Qt.locale().firstDayOfWeek + "--" + weekDay)
70 if( startOfWeek.isSameDay(startDay) && diff > 2) {69 if( startOfWeek.isSameDay(startDay) && diff > 2) {
71 timeLineView.contentX = (diff * timeLineView.delegateWidth);70 timeLineView.contentX = (diff * timeLineView.delegateWidth);
72 if( timeLineView.contentX > (timeLineView.contentWidth - timeLineView.width) ) {71 if( timeLineView.contentX > (timeLineView.contentWidth - timeLineView.width) ) {
73 timeLineView.contentX = timeLineView.contentWidth - timeLineView.width72 timeLineView.contentX = timeLineView.contentWidth - timeLineView.width
74 print(timeLineView.contentX +"----" + (timeLineView.contentWidth - timeLineView.width) )
75 }73 }
76 } else {74 } else {
77 timeLineView.contentX = 0;75 timeLineView.contentX = 0;
@@ -140,6 +138,7 @@
140 startDay: root.startDay138 startDay: root.startDay
141 contentX: timeLineView.contentX139 contentX: timeLineView.contentX
142 type: root.type140 type: root.type
141 isActive: root.isActive
143142
144 onDateSelected: {143 onDateSelected: {
145 root.dateSelected(date);144 root.dateSelected(date);
146145
=== modified file 'TimeLineHeader.qml'
--- TimeLineHeader.qml 2015-04-29 12:30:15 +0000
+++ TimeLineHeader.qml 2015-07-25 05:21:13 +0000
@@ -29,6 +29,7 @@
29 property date startDay;29 property date startDay;
30 property double contentX;30 property double contentX;
31 property int firstDayOfWeek: Qt.locale().firstDayOfWeek31 property int firstDayOfWeek: Qt.locale().firstDayOfWeek
32 property bool isActive: false;
3233
33 signal dateSelected(var date);34 signal dateSelected(var date);
3435
@@ -153,6 +154,7 @@
153 type: ViewType.ViewTypeWeek154 type: ViewType.ViewTypeWeek
154 width: parent.width155 width: parent.width
155 height: units.gu(5)156 height: units.gu(5)
157 isCurrentItem: root.isActive
156158
157 onDateSelected: {159 onDateSelected: {
158 root.dateSelected(date);160 root.dateSelected(date);
159161
=== modified file 'TimeLineHeaderComponent.qml'
--- TimeLineHeaderComponent.qml 2015-05-28 12:37:54 +0000
+++ TimeLineHeaderComponent.qml 2015-07-25 05:21:13 +0000
@@ -37,8 +37,8 @@
37 width: parent.width37 width: parent.width
38 height: units.gu(4)38 height: units.gu(4)
3939
40 onStartDayChanged: {40 onIsCurrentItemChanged: {
41 highlightedIndex = 041 highlightedIndex = -1
42 }42 }
4343
44 Repeater{44 Repeater{

Subscribers

People subscribed via source and target branches

to status/vote changes: