Merge lp:~pkunal-parmar/ubuntu-calendar-app/NoDefaultSelection_Week into lp:ubuntu-calendar-app

Proposed by Kunal Parmar
Status: Merged
Approved by: Mihir Soni
Approved revision: 699
Merged at revision: 702
Proposed branch: lp:~pkunal-parmar/ubuntu-calendar-app/NoDefaultSelection_Week
Merge into: lp:ubuntu-calendar-app
Diff against target: 71 lines (+5/-5)
4 files modified
EventListModel.qml (+0/-1)
TimeLineBaseComponent.qml (+1/-2)
TimeLineHeader.qml (+2/-0)
TimeLineHeaderComponent.qml (+2/-2)
To merge this branch: bzr merge lp:~pkunal-parmar/ubuntu-calendar-app/NoDefaultSelection_Week
Reviewer Review Type Date Requested Status
Mihir Soni Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+265889@code.launchpad.net

Commit message

By default no selection in weekview, this is current implementation in MonthView as well

Description of the change

By default no selection in weekview, this is current implementation in MonthView as well

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Mihir Soni (mihirsoni) wrote :

Looks good to me !!

Thanks Kunal

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'EventListModel.qml'
2--- EventListModel.qml 2015-05-14 13:03:02 +0000
3+++ EventListModel.qml 2015-07-25 05:21:13 +0000
4@@ -69,7 +69,6 @@
5 var collections = eventModel.collections;
6 for(var i = 0 ; i < collections.length ; ++i) {
7 var cal = collections[i];
8- //print(cal.name + " ---- " + cal.extendedMetaData("collection-readonly"));
9 if( cal.extendedMetaData("collection-type") === "Calendar" ) {
10 cals.push(cal);
11 }
12
13=== modified file 'TimeLineBaseComponent.qml'
14--- TimeLineBaseComponent.qml 2015-06-04 14:13:32 +0000
15+++ TimeLineBaseComponent.qml 2015-07-25 05:21:13 +0000
16@@ -66,12 +66,10 @@
17 var diff = weekDay - Qt.locale().firstDayOfWeek
18 diff = diff < 0 ? 6 : diff
19
20- print(diff + ", " + Qt.locale().firstDayOfWeek + "--" + weekDay)
21 if( startOfWeek.isSameDay(startDay) && diff > 2) {
22 timeLineView.contentX = (diff * timeLineView.delegateWidth);
23 if( timeLineView.contentX > (timeLineView.contentWidth - timeLineView.width) ) {
24 timeLineView.contentX = timeLineView.contentWidth - timeLineView.width
25- print(timeLineView.contentX +"----" + (timeLineView.contentWidth - timeLineView.width) )
26 }
27 } else {
28 timeLineView.contentX = 0;
29@@ -140,6 +138,7 @@
30 startDay: root.startDay
31 contentX: timeLineView.contentX
32 type: root.type
33+ isActive: root.isActive
34
35 onDateSelected: {
36 root.dateSelected(date);
37
38=== modified file 'TimeLineHeader.qml'
39--- TimeLineHeader.qml 2015-04-29 12:30:15 +0000
40+++ TimeLineHeader.qml 2015-07-25 05:21:13 +0000
41@@ -29,6 +29,7 @@
42 property date startDay;
43 property double contentX;
44 property int firstDayOfWeek: Qt.locale().firstDayOfWeek
45+ property bool isActive: false;
46
47 signal dateSelected(var date);
48
49@@ -153,6 +154,7 @@
50 type: ViewType.ViewTypeWeek
51 width: parent.width
52 height: units.gu(5)
53+ isCurrentItem: root.isActive
54
55 onDateSelected: {
56 root.dateSelected(date);
57
58=== modified file 'TimeLineHeaderComponent.qml'
59--- TimeLineHeaderComponent.qml 2015-05-28 12:37:54 +0000
60+++ TimeLineHeaderComponent.qml 2015-07-25 05:21:13 +0000
61@@ -37,8 +37,8 @@
62 width: parent.width
63 height: units.gu(4)
64
65- onStartDayChanged: {
66- highlightedIndex = 0
67+ onIsCurrentItemChanged: {
68+ highlightedIndex = -1
69 }
70
71 Repeater{

Subscribers

People subscribed via source and target branches

to status/vote changes: