Merge lp:~pkunal-parmar/ubuntu-calendar-app/Monthly-YearlyEvent into lp:ubuntu-calendar-app

Proposed by Kunal Parmar
Status: Merged
Approved by: Alan Pope 🍺🐧🐱 πŸ¦„
Approved revision: 627
Merged at revision: 626
Proposed branch: lp:~pkunal-parmar/ubuntu-calendar-app/Monthly-YearlyEvent
Merge into: lp:ubuntu-calendar-app
Diff against target: 63 lines (+32/-14)
1 file modified
EventRepetition.qml (+32/-14)
To merge this branch: bzr merge lp:~pkunal-parmar/ubuntu-calendar-app/Monthly-YearlyEvent
Reviewer Review Type Date Requested Status
Alan Pope 🍺🐧🐱 πŸ¦„ (community) Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+255919@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Alan Pope 🍺🐧🐱 πŸ¦„ (popey) wrote :

Tested on Krillin. Nice one Kunal, thanks for the fix.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'EventRepetition.qml'
--- EventRepetition.qml 2014-10-22 14:03:01 +0000
+++ EventRepetition.qml 2015-04-12 05:02:40 +0000
@@ -90,7 +90,7 @@
9090
91 }91 }
92 }92 }
93 recurrenceOption.selectedIndex = index;93 recurrenceOption.selectedIndex = index;
94 }94 }
9595
96 head.backAction: Action{96 head.backAction: Action{
@@ -100,19 +100,37 @@
100 var recurrenceRule = Defines.recurrenceValue[ recurrenceOption.selectedIndex ];100 var recurrenceRule = Defines.recurrenceValue[ recurrenceOption.selectedIndex ];
101 if (recurrenceRule !== RecurrenceRule.Invalid) {101 if (recurrenceRule !== RecurrenceRule.Invalid) {
102 rule.frequency = recurrenceRule;102 rule.frequency = recurrenceRule;
103 if (recurrenceOption.selectedIndex > 0) {103 switch(recurrenceOption.selectedIndex){
104 rule.daysOfWeek = eventUtils.getDaysOfWeek(recurrenceOption.selectedIndex,weekDays );104 case 1: //daily
105 if (limitOptions.selectedIndex === 1105 case 2: //weekly
106 && recurrenceOption.selectedIndex > 0106 case 3: //weekly
107 && limitCount.text != "") {107 case 4: //weekly
108 rule.limit = parseInt(limitCount.text);108 case 5: //weekly
109 }109 rule.daysOfWeek = eventUtils.getDaysOfWeek(recurrenceOption.selectedIndex, weekDays );
110 else if (limitOptions.selectedIndex === 2 && recurrenceOption.selectedIndex > 0) {110 break;
111 rule.limit = datePick.date;111 case 6: //monthly
112 }112 rule.daysOfMonth = [date.getDate()];
113 else {113 break;
114 rule.limit = undefined;114 case 7: //yearly
115 }115 rule.monthsOfYear = [date.getMonth()];
116 rule.daysOfMonth = [date.getDate()];
117 break;
118 case 0: //once
119 default:
120 //it should not come here
121 break;
122 }
123
124 if (limitOptions.selectedIndex === 1
125 && recurrenceOption.selectedIndex > 0
126 && limitCount.text != "") {
127 rule.limit = parseInt(limitCount.text);
128 }
129 else if (limitOptions.selectedIndex === 2 && recurrenceOption.selectedIndex > 0) {
130 rule.limit = datePick.date;
131 }
132 else {
133 rule.limit = undefined;
116 }134 }
117 }135 }
118 else {136 else {

Subscribers

People subscribed via source and target branches

to status/vote changes: