Code review comment for lp:~pkunal-parmar/ubuntu-calendar-app/LoaderPage

Revision history for this message
Kunal Parmar (pkunal-parmar) wrote :

> There are still 3 occurrences of hardcoded index assignment in calendar.qml
> (lines 183, 189, 193), and a function called
> calculateDifferenceStarttimeEndtime that returns an index as well, so you
> should remove hardcoded values from there as well.

Thanks, changed those.

« Back to merge proposal