Code review comment for lp:~pkunal-parmar/ubuntu-calendar-app/LoaderPage

Revision history for this message
Kunal Parmar (pkunal-parmar) wrote :

> > > According to the documentation (see
> > > http://developer.ubuntu.com/api/qml/sdk-14.04/Ubuntu.Components.Tabs/),
> one
> > > should avoid setting the top anchor of the Loader:
> > >
> > > « As the example above shows, an external Page inside a Tab can be
> loaded
> > > using a Loader. Note that setting the top anchor or the height of the
> Loader
> > > would override the Page height. We avoid this because the Page
> automatically
> > > adapts its height to accommodate for the header. »
> >
> > Yes, I read so, but there seems some issue somewhere in SDK, not using it is
> > making monthView disappear
> >
> > http://ubuntuone.com/6VPfdnxG8YcNl6uZVgyqTN
>
> That’s probably because the MonthView component has "anchors.fill: parent"
> defined at the top-level. Top-level components should never have anchors
> defined, it breaks encapsulation.

Actually I intentionally put anchors.fill in MomthView, As only anchors.fill in MonthView and anchors.top in Calendar, combination seems to layout MonthView properly.

In every other case it either does not show anything or leave blank space on top, like in previous snapshot.

May be its issue with my version of SDK or bug in SDK, but as of now, only this combination works.

« Back to merge proposal