Code review comment for lp:~pkunal-parmar/ubuntu-calendar-app/LoaderPage

Revision history for this message
Olivier Tilloy (osomon) wrote :

> > According to the documentation (see
> > http://developer.ubuntu.com/api/qml/sdk-14.04/Ubuntu.Components.Tabs/), one
> > should avoid setting the top anchor of the Loader:
> >
> > « As the example above shows, an external Page inside a Tab can be loaded
> > using a Loader. Note that setting the top anchor or the height of the Loader
> > would override the Page height. We avoid this because the Page automatically
> > adapts its height to accommodate for the header. »
>
> Yes, I read so, but there seems some issue somewhere in SDK, not using it is
> making monthView disappear
>
> http://ubuntuone.com/6VPfdnxG8YcNl6uZVgyqTN

That’s probably because the MonthView component has "anchors.fill: parent" defined at the top-level. Top-level components should never have anchors defined, it breaks encapsulation.

« Back to merge proposal