Code review comment for lp:~pkunal-parmar/ubuntu-calendar-app/LoaderPage

Revision history for this message
Kunal Parmar (pkunal-parmar) wrote :

> 476 +
> item.monthSelected.connect(yearPage.monthSelected);
>
> 517 +
> item.dateSelected.connect(monthPage.dateSelected);
>
> For consistency, and because declarative code is easier to read and maintain,
> you should use a Connections item, like in weekPage and dayPage.

Changed

« Back to merge proposal