Merge lp:~pkunal-parmar/ubuntu-calendar-app/LoadeAsyncProp into lp:ubuntu-calendar-app

Proposed by Kunal Parmar
Status: Merged
Approved by: Mihir Soni
Approved revision: 536
Merged at revision: 536
Proposed branch: lp:~pkunal-parmar/ubuntu-calendar-app/LoadeAsyncProp
Merge into: lp:ubuntu-calendar-app
Diff against target: 25 lines (+2/-2)
2 files modified
DayView.qml (+1/-1)
WeekView.qml (+1/-1)
To merge this branch: bzr merge lp:~pkunal-parmar/ubuntu-calendar-app/LoadeAsyncProp
Reviewer Review Type Date Requested Status
Mihir Soni Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+240851@code.launchpad.net

Commit message

Loader async property for DayView and WeekView corrected

Description of the change

Loader async property for DayView and WeekView corrected

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Mihir Soni (mihirsoni) wrote :

LGTM !!
Thanks Kunal !!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'DayView.qml'
--- DayView.qml 2014-10-22 18:46:59 +0000
+++ DayView.qml 2014-11-06 13:59:08 +0000
@@ -121,7 +121,7 @@
121 delegate: Loader {121 delegate: Loader {
122 width: parent.width122 width: parent.width
123 height: parent.height123 height: parent.height
124 asynchronous: !dayViewPath.isCurrentItem124 asynchronous: index !== dayViewPath.currentIndex
125 sourceComponent: delegateComponent125 sourceComponent: delegateComponent
126126
127 Component {127 Component {
128128
=== modified file 'WeekView.qml'
--- WeekView.qml 2014-10-22 18:46:59 +0000
+++ WeekView.qml 2014-11-06 13:59:08 +0000
@@ -109,7 +109,7 @@
109 delegate: Loader {109 delegate: Loader {
110 width: parent.width110 width: parent.width
111 height: parent.height111 height: parent.height
112 asynchronous: !weekViewPath.isCurrentItem112 asynchronous: index !== weekViewPath.currentIndex
113 sourceComponent: delegateComponent113 sourceComponent: delegateComponent
114114
115 Component{115 Component{

Subscribers

People subscribed via source and target branches

to status/vote changes: