Merge lp:~pkunal-parmar/ubuntu-calendar-app/LoadeAsyncProp into lp:ubuntu-calendar-app

Proposed by Kunal Parmar
Status: Merged
Approved by: Mihir Soni
Approved revision: 536
Merged at revision: 536
Proposed branch: lp:~pkunal-parmar/ubuntu-calendar-app/LoadeAsyncProp
Merge into: lp:ubuntu-calendar-app
Diff against target: 25 lines (+2/-2)
2 files modified
DayView.qml (+1/-1)
WeekView.qml (+1/-1)
To merge this branch: bzr merge lp:~pkunal-parmar/ubuntu-calendar-app/LoadeAsyncProp
Reviewer Review Type Date Requested Status
Mihir Soni Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+240851@code.launchpad.net

Commit message

Loader async property for DayView and WeekView corrected

Description of the change

Loader async property for DayView and WeekView corrected

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Mihir Soni (mihirsoni) wrote :

LGTM !!
Thanks Kunal !!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'DayView.qml'
2--- DayView.qml 2014-10-22 18:46:59 +0000
3+++ DayView.qml 2014-11-06 13:59:08 +0000
4@@ -121,7 +121,7 @@
5 delegate: Loader {
6 width: parent.width
7 height: parent.height
8- asynchronous: !dayViewPath.isCurrentItem
9+ asynchronous: index !== dayViewPath.currentIndex
10 sourceComponent: delegateComponent
11
12 Component {
13
14=== modified file 'WeekView.qml'
15--- WeekView.qml 2014-10-22 18:46:59 +0000
16+++ WeekView.qml 2014-11-06 13:59:08 +0000
17@@ -109,7 +109,7 @@
18 delegate: Loader {
19 width: parent.width
20 height: parent.height
21- asynchronous: !weekViewPath.isCurrentItem
22+ asynchronous: index !== weekViewPath.currentIndex
23 sourceComponent: delegateComponent
24
25 Component{

Subscribers

People subscribed via source and target branches

to status/vote changes: