Code review comment for lp:~pkunal-parmar/ubuntu-calendar-app/Key_Navi

Revision history for this message
Kunal Parmar (pkunal-parmar) wrote :

> > This line looks strange:
> > Keys.forwardTo:
> > [yearView,monthView,weekView,dayView,pageStack.currentPage,tabPage]
> > because of using "pageStack.currentPage". Is it necessary?
>
> I agree, that should be enought, I will change

Somehow if keys are not forwarded to individual views then they are not getting key events.

I am refacroring the cal app and planning to load only one view at a time.
I will handle this properly there. as I need to change this code anyhow that time

« Back to merge proposal