Merge ~pjdc/charm-k8s-mattermost/+git/charm-k8s-mattermost:default-image into charm-k8s-mattermost:master

Proposed by Paul Collins
Status: Merged
Approved by: Haw Loeung
Approved revision: 80f8d72a8142b80b6f6c974bcd561836a425c6a2
Merged at revision: 7ba197ca5c1ee9b849efd071954e1ee939d5dd08
Proposed branch: ~pjdc/charm-k8s-mattermost/+git/charm-k8s-mattermost:default-image
Merge into: charm-k8s-mattermost:master
Diff against target: 61 lines (+16/-7)
2 files modified
README.md (+15/-6)
config.yaml (+1/-1)
Reviewer Review Type Date Requested Status
Haw Loeung Approve
Canonical IS Reviewers Pending
Review via email: mp+392916@code.launchpad.net

Commit message

use default image mattermostcharmers/mattermost:edge, adjust README.md to suit

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Haw Loeung (hloeung) wrote :

LGTM

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 7ba197ca5c1ee9b849efd071954e1ee939d5dd08

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/README.md b/README.md
index 81f6a2a..08bd581 100644
--- a/README.md
+++ b/README.md
@@ -27,7 +27,6 @@ Notes for deploying a test setup locally using microk8s:
27 sudo snap alias microk8s.kubectl kubectl27 sudo snap alias microk8s.kubectl kubectl
28 sudo snap install charmcraft28 sudo snap install charmcraft
29 git clone https://git.launchpad.net/charm-k8s-mattermost29 git clone https://git.launchpad.net/charm-k8s-mattermost
30 git clone https://git.launchpad.net/~mattermost-charmers/charm-k8s-mattermost/+git/image-build mattermost-image-build
31 make -C charm-k8s-mattermost mattermost.charm30 make -C charm-k8s-mattermost mattermost.charm
3231
33 microk8s.reset # Warning! Clean slate!32 microk8s.reset # Warning! Clean slate!
@@ -35,13 +34,9 @@ Notes for deploying a test setup locally using microk8s:
35 microk8s.status --wait-ready34 microk8s.status --wait-ready
36 microk8s.config | juju add-k8s myk8s --client35 microk8s.config | juju add-k8s myk8s --client
3736
38 # Build your Mattermost image
39 docker build -t localhost:32000/mattermost ./mattermost-image-build
40 docker push localhost:32000/mattermost
41
42 juju bootstrap myk8s37 juju bootstrap myk8s
43 juju add-model mattermost-test38 juju add-model mattermost-test
44 juju deploy ./charm-k8s-mattermost/mattermost.charm --config mattermost_image_path=localhost:32000/mattermost:latest mattermost39 juju deploy ./charm-k8s-mattermost/mattermost.charm mattermost
45 juju wait40 juju wait
46 juju status41 juju status
4742
@@ -70,6 +65,20 @@ know what the source addresses or address range is for the next step.
70(In the case of postgresql, `--via` is needed so that the charm can65(In the case of postgresql, `--via` is needed so that the charm can
71configure `pga_hba.conf` to let the k8s pods connect to the database.)66configure `pga_hba.conf` to let the k8s pods connect to the database.)
7267
68## Using a Custom Image
69
70 git clone https://git.launchpad.net/~mattermost-charmers/charm-k8s-mattermost/+git/image-build mattermost-image-build
71 docker build -t localhost:32000/mattermost ./mattermost-image-build
72 docker push localhost:32000/mattermost
73
74Then, to use your new image, either replace the `deploy` step above with
75
76 juju deploy ./charm-k8s-mattermost/mattermost.charm --config mattermost_image_path=localhost:32000/mattermost:latest mattermost
77
78or, if you've already deployed mattermost:
79
80 juju config mattermost mattermost_image_path=localhost:32000/mattermost:latest
81
73## Authentication82## Authentication
7483
75This charm supports configuring [Ubuntu SSO](https://login.ubuntu.com)84This charm supports configuring [Ubuntu SSO](https://login.ubuntu.com)
diff --git a/config.yaml b/config.yaml
index 438cd45..34ac0a8 100644
--- a/config.yaml
+++ b/config.yaml
@@ -40,7 +40,7 @@ options:
40 The location of the image to use, e.g. "registry.example.com/mattermost:v1".40 The location of the image to use, e.g. "registry.example.com/mattermost:v1".
4141
42 This setting is required.42 This setting is required.
43 default: ''43 default: mattermostcharmers/mattermost:edge
44 mattermost_image_username:44 mattermost_image_username:
45 type: string45 type: string
46 description: |46 description: |

Subscribers

People subscribed via source and target branches