Code review comment for lp:~pitti/ubuntuone-client/gi-fixes

Revision history for this message
Martin Pitt (pitti) wrote :

Unfortunately not. The conditional static/GI import needs to stay until all users of python-ubuntone are converted to use GI. With pygobject >= 2.90 you cannot mix static and GI imports, and the ubuntuone-control-panel is still using pygtk, gobject, etc. See the description of bug 828751 for the background why we have to do this.

For the record, I also already had the test suite of this ported to GI. However, that does not work, as the test suite uses twisted, which uses static gtk/gobject modules. So I'm afraid for the time being the test suite can only check the static part here, not the GI part.

« Back to merge proposal