Code review comment for lp:~pitti/ubuntu-sso-client/gi-fixes

Natalia Bidart (nataliabidart) wrote :

Hi Martin!

The branch looks great, I'm approving. In order to have this branch being landed by tarmac (our bot lander), we'll need that the test run (triggered by ./run-tests) reports no lint errors. ATM, in natty, I'm getting this:

ubuntu_sso/utils/txsecrets.py:
    28: [E0611] No name 'GObject' in module 'gi.repository'

You need to wrap the from gi.repository import GObject like this:

else:
    # pylint: disable=E0611
    from gi.repository import GObject
    # pylint: enable=E0611

review: Approve

« Back to merge proposal